Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Album info files view was broken #4394

Merged
merged 2 commits into from Mar 11, 2014

Conversation

Projects
None yet
2 participants
Member

jmarshallnz commented Mar 11, 2014

With the new library stuff, albums require songs in the library. Thus, only show the album information item in context if this is the case.

Further, drop the old code as it's no longer needed.

@t-nelson please take a look.

@night199uk if you have time, a look would be good.

Jonathan Marshall added some commits Mar 11, 2014

Jonathan Marshall [music] Album Information on a folder in files mode wasn't working. f…
…ixes #14874
bca0895
Jonathan Marshall [music] drop code that fetched directory/tags to try and find album i…
…nfo on a folder - album info requires the songs are scanned first.
094feaa
Contributor

t-nelson commented Mar 11, 2014

Looks good

jenkins build this please

@jmarshallnz jmarshallnz added a commit that referenced this pull request Mar 11, 2014

@jmarshallnz jmarshallnz Merge pull request #4394 from jmarshallnz/album_info_files
Album info files view was broken
e133173

@jmarshallnz jmarshallnz merged commit e133173 into xbmc:master Mar 11, 2014

1 check passed

default Merged build #353 succeeded in 1 hr 10 min
Details

@jmarshallnz jmarshallnz deleted the jmarshallnz:album_info_files branch Mar 11, 2014

@jmarshallnz jmarshallnz added this to the Gotham13.0-beta2 milestone Mar 11, 2014

@jmarshallnz jmarshallnz added the Gotham label Mar 11, 2014

@jmarshallnz jmarshallnz added a commit that referenced this pull request Mar 11, 2014

@jmarshallnz jmarshallnz + Jonathan Marshall Merge pull request #4394 from jmarshallnz/album_info_files
Album info files view was broken
b66609f

@jmarshallnz jmarshallnz removed the Gotham label Mar 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment