[osx] vsync should default to always

[jmarshallnz]

@Montellese I'm not sure if there's a universal way to solve this.

I just copy n pasted the existing win32/android override.

It may also need overriding elsewhere, not sure. @popcornmix rpi maybe?

[popcornmix]

You mean like this: https://github.com/xbmc/xbmc/blob/master/system/settings/rbp.xml#L53

[jmarshallnz]

Heh - I missed that one, yup.

[jmarshallnz]

I've updated this with an updater that ignores the incorrect value.

I've also switched the default in settings.xml to VSYNC_ALWAYS. This means that the quirks are around the other way, so in Linux, Android + FreeBSD I've quirked to VSYNC_DRIVER.

This should in theory be identical to what we had before, but be more resilient, as only those platforms that support VSYNC_DRIVER have it defaulted as such.

[jmarshallnz]

@Montellese, @t-nelson, please sanity check :)

[Montellese]

The settings stuff looks fine but I don't know on which platforms VSYNC_DRIVER is available and makes sense.

[davilla]

VSYNC for Android please.

[jmarshallnz]

@davilla: Should VSYNC_DRIVER even be an option for vsync on android? (ATM you have it available in the setting as android defines TARGET_POSIX right?)

@popcornmix: I guess the same question could be asked of RPi.

[davilla]

VSYNC_DRIVER is never for Android, never on Arm/Linux. VSYNC_DRIVER seems to be some sort of desktop/linux hack around misbehaving video drivers. So if there is no X11 (maybe wayland too), then no need for it to even show.

[jmarshallnz]

OK, I'll ifdef out for android as well in that case (I'm guessing also RPi, but I'll wait on popcornmix).

Pity that everyone still defines TARGET_LINUX :)

[jmarshallnz]

@davilla mind taking a look at the ifdef's in 997bb53

[davilla]

Not for at least 24+ hours. About to enter a closed Al tube for 6 hours.

[davilla]

hehe, I took a peek, looks ok.

[jmarshallnz]

Thanks :)

[popcornmix]

VSYNC_DRIVER doesn't make any sense on Pi.
VSYNC should always be enabled really (except maybe for benchmarking).

[jmarshallnz]

Thanks - I'll add RPi to the ifdef (by the looks RPi specifies TARGET_LINUX)

[jmarshallnz]

Ok, removed the option from rpi as well. @popcornmix if you could check the ifdefs here that'd be great.

jenkins build this please

[popcornmix]

Looks okay to me. VSYNC_DRIVER has gone from list, and Always Enabled is the default.

[jmarshallnz]

thanks :)