[appmessenger] fix playfile regression introduced by f86b9d2 #4993

Merged
merged 1 commit into from Jul 9, 2014

3 participants

@mkortstiege
Team Kodi member

Not sure if it's a valid fix, so @jmarshallnz for review please.

@jmarshallnz
Team Kodi member

This seems odd - what's the reason we need to change to -1 ?

@mkortstiege
Team Kodi member

Looks like param2 now is always 0 when called from json and others. Not sure how to fix it other than making sure it's something else and not really sure why it worked before ;/ Just fixed it according to my findings when checking @popcornmix's report.

@jmarshallnz
Team Kodi member

How is it zero? TMSG_MEDIA_PLAY is as far as I can tell completely local to CApplicationMessenger. There, it's only ever set to 0, a songid (never zero) or 2, no?

@mkortstiege
Team Kodi member

Jep, that was exactly what i thought when reading it, but for some reason it's not working as intended with the latest unsigned/signed msgs change. Unfortunately, I can't explain it any better. TBH.. just put this one up to get some attention - which obviously worked ;)

@jmarshallnz
Team Kodi member

The real problem is a few lines up - will comment on it in the original patch if you don't mind fixing (I have no easy access atm)

@mkortstiege
Team Kodi member

Updated, thanks. OK to merge without further test i assume?

@jmarshallnz
Team Kodi member

Cheers!

@jmarshallnz jmarshallnz merged commit af67986 into xbmc:master Jul 9, 2014
@jmarshallnz
Team Kodi member

Yup ;)

@mkortstiege
Team Kodi member
@MartijnKaijser MartijnKaijser added this to the Helix 14.0-alpha1 milestone Jul 16, 2014
@mkortstiege mkortstiege deleted the mkortstiege:playfile branch Aug 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment