Not sure if it's a valid fix, so @jmarshallnz for review please.
[appmessenger] make ThreadMessage's parameters signed integers
This seems odd - what's the reason we need to change to -1 ?
Looks like param2 now is always 0 when called from json and others. Not sure how to fix it other than making sure it's something else and not really sure why it worked before ;/ Just fixed it according to my findings when checking @popcornmix's report.
How is it zero? TMSG_MEDIA_PLAY is as far as I can tell completely local to CApplicationMessenger. There, it's only ever set to 0, a songid (never zero) or 2, no?
Jep, that was exactly what i thought when reading it, but for some reason it's not working as intended with the latest unsigned/signed msgs change. Unfortunately, I can't explain it any better. TBH.. just put this one up to get some attention - which obviously worked ;)
The real problem is a few lines up - will comment on it in the original patch if you don't mind fixing (I have no easy access atm)
[appmessenger] fix MediaPlay regression introduced by f86b9d2
Updated, thanks. OK to merge without further test i assume?