Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Darwin host identification #5001

Merged
merged 5 commits into from Aug 2, 2014
Merged

Conversation

Karlson2k
Copy link
Member

This PR should replace hardcoded kernel architecture for Darwin iOS with real architecture detection.
Also kernel bitness should be fixed for Darwin iOS.
Additionally SysInfo::GetKernelBitness and SysInfo::GetKernelCpuFamily now cache values instead of detection each time.
OS X detection was checked locally, iOS detection should work according to http://blog.timac.org/?p=907 and source code of NXGetLocalArchInfo().
It wold be great if some darwin dev will be able to check it on real Arm64 device.

@Memphiz @jmarshallnz ?

@Memphiz
Copy link
Member

Memphiz commented Jul 11, 2014

Can check ios 32bit on monday earliest - i am back at home for ios 64Bit and atv2 on wednesday or if i miss my short time slot - the monday after...

@Karlson2k
Copy link
Member Author

@Memphiz Don't waste your time on iOS 32bit - this will work for sure.
Check only 64bit OS detection for 32bit app.

@Memphiz
Copy link
Member

Memphiz commented Jul 14, 2014

Based on this - would you be able to fix https://github.com/xbmc/xbmc/blob/master/xbmc/utils/CPUInfo.cpp#L132 for ios aswell? atm the CPU model and vendor is returned as empty (as "machdep.cpu.brand_string" and "machdep.cpu.vendor" are not implemented on ios).

@Karlson2k
Copy link
Member Author

Rebased
@Memphiz I can implement only basic CPU detection. iOS don't give you any detailed CPU information.

@MartijnKaijser MartijnKaijser added this to the Pending for inclusion milestone Jul 16, 2014
@Memphiz
Copy link
Member

Memphiz commented Jul 16, 2014

@Karlson2k this is the log from a 64bit ios device - is this ok?

http://pastebin.com/yHBg9ums

@Karlson2k
Copy link
Member Author

@Memphiz Thanks a lot! Yes, it works!

@Karlson2k
Copy link
Member Author

Everything works, let's check by jenkins

jenkins build this please

@Karlson2k
Copy link
Member Author

jenkins is fine, android fail is unrelated.

@MartijnKaijser
Copy link
Member

jenkins build this please

@MartijnKaijser MartijnKaijser modified the milestones: Pending for inclusion, Helix 14.0-alpha3 Aug 2, 2014
jmarshallnz added a commit that referenced this pull request Aug 2, 2014
@jmarshallnz jmarshallnz merged commit 8dd4bee into xbmc:master Aug 2, 2014
@Karlson2k Karlson2k deleted the darwin_host_id_01 branch August 3, 2014 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants