Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pvr] bump api to 1.9.1 #5012

Merged
merged 2 commits into from Jul 14, 2014
Merged

[pvr] bump api to 1.9.1 #5012

merged 2 commits into from Jul 14, 2014

Conversation

xhaggi
Copy link
Member

@xhaggi xhaggi commented Jul 12, 2014

@opdenkamp something missing?

The addon sync will be added after bump version in addon repo.

@opdenkamp
Copy link
Member

yes. since this is a possible breaking change (size of a type changed), you need to bump the minimum version #define too. then, each time the api changes, you need to bump the version number of all add-ons in the pvr repository. this will ensure that xbmc pulls in the rebuilt add-on that uses the updated api.

also, next time a breaking api change is introduced, it must be accompanied by a corresponding PR for the add-ons repos, that's merged first. then create an add-on hash bump commit to the PR that changes the API on XBMC's side. only then should the green button be pressed on the PR.

@xhaggi
Copy link
Member Author

xhaggi commented Jul 13, 2014

thanks for clarifying this, I might have guessed.

@xhaggi
Copy link
Member Author

xhaggi commented Jul 14, 2014

@opdenkamp ready to go?

opdenkamp pushed a commit that referenced this pull request Jul 14, 2014
@opdenkamp opdenkamp merged commit ce76240 into xbmc:master Jul 14, 2014
@xhaggi
Copy link
Member Author

xhaggi commented Jul 14, 2014

thanks ;)

@MartijnKaijser MartijnKaijser added this to the Helix 14.0-alpha1 milestone Jul 16, 2014
@xhaggi xhaggi deleted the pvr-bump-api-version branch July 17, 2014 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants