Updated metadata parsing for pictures #508

Merged
3 commits merged into from Mar 27, 2012

Conversation

Projects
None yet
2 participants
Member

fetzerch commented Oct 22, 2011

IptcParser: Updated the iptc parser code (from the public domain software jhead). IPTC data that commercial tools (like Adobe PS and Lightroom) produce were not readable by xbmc. This improved parser now supports recent IPTC versions.

ExifParser: Added support for the exif tag ImageDescription. The code that presents the info to the ui was already there; only a few lines in the parser were missing.

@ghost

ghost commented Oct 27, 2011

hmm, 7ca03bb is something i want to pull for eden. do you have some format doc links so it can be verified?

@ghost

ghost commented Oct 27, 2011

to clarify; i can't find good docs so just asking. pushed the fix, the rest will go in after the feature freeze. thanks

Member

fetzerch commented Oct 28, 2011

First of all: Thanks for pulling my first (even so very small) contribution to xbmc :-)

When I noticed that the IPTC parser wasn't working with newer jpegs, i had a look into the sources and saw that the code was taken from http://www.sentex.net/~mwandel/jhead/. I updated only the IPTC code according to the latest version and roughly verified the changes with http://www.codeproject.com/KB/graphics/iptc.aspx?msg=614530

The relevant (but hard to read) spec would be the Photoshop File Format which references IPTC IIM:
http://www.adobe.com/devnet-apps/photoshop/fileformatashtml/PhotoshopFileFormats.htm#50577409_pgfId-1037504
http://www.iptc.org/std/IIM/4.1/specification/IIMV4.1.pdf

My pictures are working fine of course but indeed this should be tested by a few other users. So it's probably better to merge it after the feature freeze.

@ghost

ghost commented Mar 25, 2012

ping. please rebase

Member

fetzerch commented Mar 26, 2012

done

what's the magic number? MAX_COMMENT ?

Owner

fetzerch replied Mar 27, 2012

Exactly. I just copied that from TAG_USERCOMMENT in line 455. Will change it in both to MAX_COMMENT.

any reason we're just commenting code out?

Member

jmarshallnz commented Mar 26, 2012

Just a couple of minors spotted, otherwise nice work.

Cleaned up exif parser: Removed unneccessary comment, use MAX_COMMENT…
… instead of constant, replaced sizeof(short) by 2 (might cause toubles on future platforms)
Member

fetzerch commented Mar 27, 2012

Thanks for reviewing :-)
I just updated the code according to your comments

@ghost

ghost commented Mar 27, 2012

thanks for the reponsiveness and patience.

ghost pushed a commit that referenced this pull request Mar 27, 2012

@ghost ghost merged commit 4239991 into xbmc:master Mar 27, 2012

FernetMenta referenced this pull request in FernetMenta/xbmc Jun 15, 2012

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment