Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[rbp] Make gui limit default to 720 when memory is limited #5094
I'm not sure about "unlimited" - it sounds odd - especially because there is still a limit. Does the PI allow resolutions beyond 1080p in case display would support it? I'd probably name it what it is "1080p" and make the "auto" mode more intelligent and only use the actual display resolution in case of enough GPU mem but display is running a smaller res (or is using composite). If it's already limited to display res, all is fine, but i'd still label it 1080
All the values are upper limits, rather than actual resolution used.
I could change the number used by unlimited, from 1080 to any arbitrarily large number (e.g. 2160) and it will behave the same.
1080p is the highest resolution I've ever seen anyone using. I guess with custom modes you could push it higher (I have seen reports of the Pi driving a 4K display, but I'm guessing performance wouldn't be great).
So, nothing too bad happens, but it won't stay permanently on auto. This means switching an sdcard from a Pi with less memory to one with more memory won't magically alter the resolution.
So, I've updated to avoid using the setting for the automatically chosen resolution. This means that the setting stays on auto, and the resolution is chosen on each boot. I agree that is better behaviour.
jenkins build this please