[python] deprecate Monitor.onAbortRequested #5344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is almost always used incorrectly causing only confusion believing it will be reliably called when abort is requested. I fail to see any use case for it as it is now.
According to the original PR #1053, it was added so it could "replace[..] checking for xbmc.abortRequested in a while loop". This could never work since the main thread have to be kept alive and non-blocking to receive callbacks, and for that you will need another mechanism to wait for the callback itself.