Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] deprecate Monitor.onAbortRequested #5344

Merged
merged 1 commit into from Sep 18, 2014

Conversation

tamland
Copy link
Member

@tamland tamland commented Sep 9, 2014

This is almost always used incorrectly causing only confusion believing it will be reliably called when abort is requested. I fail to see any use case for it as it is now.

According to the original PR #1053, it was added so it could "replace[..] checking for xbmc.abortRequested in a while loop". This could never work since the main thread have to be kept alive and non-blocking to receive callbacks, and for that you will need another mechanism to wait for the callback itself.

@tamland tamland changed the title [python] remove/deprecate Monitor.onAbortRequested() [python] deprecate Monitor.onAbortRequested Sep 18, 2014
MartijnKaijser added a commit that referenced this pull request Sep 18, 2014
[python] deprecate Monitor.onAbortRequested
@MartijnKaijser MartijnKaijser merged commit 4d483d5 into xbmc:master Sep 18, 2014
@MartijnKaijser MartijnKaijser added this to the Helix 14.0-alpha4 milestone Sep 18, 2014
@tamland tamland deleted the deprecate-onabortrequested branch August 9, 2015 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants