[AE] Add resample factory and Pi accelerated resampling #5479
Conversation
popcornmix
force-pushed
the
resample_factory
branch
2 times, most recently
from
a3bf3a8 to
ce0cafb
Compare
|
Looks fine and I can confirm the low risk. Apart from some renaming it does not touch existing behavior. |
|
jenkins build this please |
|
@popcornmix i made a pull request to your branch with sync of xcode and visual studio projects (should cure the build errors). |
|
Thanks @Memphiz. jenkins build this please |
|
@FernetMenta any comments? (win32 fail unrelated) |
|
jenkins build this please |
|
@MartijnKaijser comment referring to what? Anything changed after my first comment here? |
|
ah missed that you already commented. sorry. |
This replaces the format conversion, up/down mixing and resampling code from ActiveAE with a GPU accelerated version. Should significantly reduce CPU when using paplayer or dvdplayer. Requires updated firmware
popcornmix
force-pushed
the
resample_factory
branch
from
a1a70f4 to
f3653ee
Compare
|
@FernetMenta @popcornmix Helix or Helix+1? |
|
I'd prefer Helix if that's acceptable. |
|
I'm fine with it :) @FernetMenta you too I reckon from your first response? |
|
Yes, I am fine with it too |
|
Jenkins build this please |
|
jenkins build this please (lowercase ;) ) |
[AE] Add resample factory and Pi accelerated resampling
5 participants
The Pi's GPU supports high quality resampling, format conversion and up/down mixing.
This PR creates a factory for different resample implementations, moves the current one into ResampleFFMPEG, and adds a ResamplePi GPU accelerated implementation.
More likely for Helix+1 (although it should be low risk), but submitting for visibility.