[osx/preflight] - add allowsharing tag to default sources.xml #5518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memphiz
force-pushed
the
allowsharingdefaultsources
branch
from
85ffc7c
to
c42a46e
Compare
|
Looks good. A bit off topic maybe but why is "/" added? |
|
Thats one good question - the other would be who added the linux part at all and who uses that linux part (nobody from our code does at least). |
|
I've tried to find where does all my support comes for all those /media sources without allowsharing. And I looked on all public build script like openelec and others and can't find any other place on Internet with this path by default. So there is someone somewhere that have this linux part running for some builds :( |
|
runtime tested - seems to work on osx |
topfs2
added a commit
that referenced
this pull request
Oct 17, 2014
[osx/preflight] - add allowsharing tag to default sources.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least if it is not the root folder "/" to be shared.
As pointed out by @Tolriq in pr #5492
Needs runtime testing...