[confluence] fix default focus in ProfileSettings.xml (fixes #15507) #5591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That fixes it, many thanks Montellese! |
|
thx, the defaultcontrol definition is indeed incorrect. it's strange that it works in gotham without issues though.. |
ronie
added a commit
that referenced
this pull request
Oct 28, 2014
[confluence] fix default focus in ProfileSettings.xml (fixes #15507)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes http://trac.xbmc.org/ticket/15507. Right now no control is focused when opening a CGUIDialogProfileSettings dialog because of an invalid
<defaultcontrol>definition in Confluence's ProfileSettings.xml. There's no control with ID1in CGUIDialogProfileSettings and CGUIDialogSettingsBase (from which CGUIDilaogProfileSettings is derived (indirectly)) already contains logic to automatically set the focus to the first control in the list.The only thing I'm wondering about is whether it should be possible to focus the image control. But it looks like there's no logic in CGUIDialogProfileSettings that would allow a user to choose a different profile image.
@ronie for review please.