libcmyth fix for negative program length on occasion #605

Merged
merged 1 commit into from Jan 5, 2012

Projects

None yet

2 participants

@dteirney
Team Kodi member

Using a pull request from my old libcmyth branch because I don't have time to update to master and push in from there. This should be a fast-forward so perhaps I still could have pushed to master.

David Teirney Fixed overflow error with long long being cast to a long resulting in…
… a negative number on occasion. Typically this seems to have effected the program length of recordings. Thanks to Charles Barnwell from the MVPMC community for the patch.
e8a7c63
@dteirney
Team Kodi member

@elupus, do you care to review any of the libcmyth stuff anymore? This change has been submitted to the upstream cmyth repository that is now on github.

@elupus
Team Kodi member
@dteirney
Team Kodi member

Yeah, all of libcmyth is still long and long long. It should all be changed to int32_t and int64_t. I'll look at doing that when I start adding support for Myth 0.25 because there are lots of other places in the protocol that now send back a 64bit int rather than the 2 32ibt integers that get smashed together to create the 64 bit.

@elupus
Team Kodi member

Ok, then merge away.

@elupus
Team Kodi member

And yes, I'll still do code review on libcmyth. Won't be testing anything thou. Anything simple you can just commit right away.

@dteirney dteirney merged commit d230ebd into xbmc:master Jan 5, 2012
@tru tru added a commit to plexinc/plex-home-theater-public that referenced this pull request Sep 5, 2013
@tru tru Pull all plex related globals into PlexApplication to ease shutdown
Related to #605
2e86bce
@tru tru added a commit to plexinc/plex-home-theater-public that referenced this pull request Sep 5, 2013
@tru tru Handle timeout abort in NetworkServicesBrowser
Related to #605
8e2f672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment