i.MX6 rework which decouples GUI (fb0) and video rendering (fb1), framebuffers are composed with DP in hw #6351

smallint · 2015-02-05T20:31:39Z

This is another rework of the i.IMX6 decoding and rendering path that supersedes #5805. More details in http://forum.kodi.tv/showthread.php?tid=211289&pid=1892440#pid1892440.

Excerpt of architecture:

Instead of render VPU decoded buffers with GPU (which involves expensive memory copy operations in combination with de-interlacing) we now render exclusively to another hardware framebuffer (fb1)
Rendering directly to this new framebuffer can be combined with de-interlacing in one step
DP combines both framebuffers in hardware with alpha blending (if 32bpp) or colour keying (if 16bpp)
Together with the optimizations brought in by @FernetMenta regarding video rendering we can now even achieve double rate de-interlacing of 1080i streams
In a nutshell: video rendering with GPU is bad, IPU is good

What does not work yet:

~~RenderCapture~~

TODOs:

Find a better place for class CIMXContext which is currently part of the decoder implementation but required on some other places as well

Recommendations for client setup:

enable VPU@352Mhz in kernel
setup 32 bit framebuffer in uEnv.txt (bpp=32)
disable console blanking in uEnv.txt (consoleblank=0)

Have fun!

smallint · 2015-02-05T20:35:49Z

One additional note: algorithmdirtyregions must be set to either 0 or 3. 1 and 2 do not work for the time being. I suppose that is a side effect of the hardware clipping work in progress.

xbmc/cores/VideoRenderers/LinuxRendererGLES.cpp

@@ -618,7 +663,6 @@ void CLinuxRendererGLES::FlipPage(int source)
    m_iYV12RenderBuffer = NextYV12Texture();

  m_buffers[m_iYV12RenderBuffer].flipindex = ++m_flipindex;
-


FernetMenta · 2015-02-06T18:16:30Z

this is mostly code exclusively used by MX6 which you know best. the other code looks ok to me.

fritsch · 2015-02-06T19:06:24Z

On the raspberry PI the gui update is slowed down, when in video mode. I tried this afternoon to apply the specific patch also to the imx work, but it works a bit different.

Is there a chance that we e.g. throttle the OSD rendering, codec screen, when playing fullscreen video?

That would help imx, wetek and all those a lot. But is slightly off topic here.

smallint · 2015-02-06T20:19:45Z

@koying, it would be interesting if that PR works on Android as well. If not it is most likely just a matter of device names which are different there. If it won't work at all I could still activate the old path and your Bob deinterlacer for Android. I would like to avoid to break Android support with that PR.

wolfgar · 2015-02-07T03:59:54Z

Thanks a lot smallint for this PR.
I am definitively convinced that this approach is the one which gets the best out of the imx6 architecture...

koying · 2015-02-07T07:32:07Z

@smallint Would you mind adding a high level description of the new architecture in the PR header, please.
Both for my comprehension and for future reference ;)

[EDIT] in tl;dr style, I mean ;)

smallint · 2015-02-07T09:39:45Z

@koying, I tried ... OK?

koying · 2015-02-07T09:58:09Z

Perfect thanks. Re your initial question, it works the same way with amlogic, so if the permissions are set right in the FW, we should be able to do the same thing on android.

…OTION_DOUBLE

…/showthread.php?tid=211289&pid=1892440#pid1892440

blit fb using g2d when no deinterlacing is required

smallint · 2015-02-20T21:17:00Z

Latest changes and impressive improvements from @wolfgar merged (thanks) and tested. RenderCapture was added and this PR is now complete.

fritsch · 2015-02-20T21:52:25Z

Then let's build it. Thank you very much for bringing IMX to a new level.

jenkins build this please

wolfgar · 2015-02-21T20:22:49Z

Thanks a lot for your tremendous work on this rendering refactoring @smallint
I have just tested that the current rebase works fine
To me it is all good for merge...

fritsch · 2015-02-21T22:17:20Z

Oki - final build after laster build and that's wait for @FernetMenta final ack.

jenkins build this please

Edit: jenkins build to only show, we did not regress other platforms.

wolfgar · 2015-02-21T22:57:42Z

To fix little remaining build issue : wolfgar@e9b6dfe

fritsch · 2015-02-21T23:28:17Z

Little compiler warning: https://github.com/smallint/xbmc/blob/1597ceda6e8c9ca8355e970d8e261d61ee7afcad/xbmc/cores/dvdplayer/DVDCodecs/Video/DVDVideoCodecIMX.cpp#L1483

this should be void or return some bool?

FernetMenta · 2015-02-22T07:11:09Z

+1

fritsch · 2015-02-22T07:54:41Z

jenkins build this please

MartijnKaijser · 2015-02-22T09:16:13Z

feature merge window is closed so this can go in 1 March

fritsch · 2015-02-22T09:30:11Z

Sorry for yet another build, did not see that: wolfgar@e9b6dfe was not yet picked.

FernetMenta · 2015-02-22T09:45:36Z

we agreed that we start Match 1st with new process. currently we don't have a merge window, means this can go in when ready. I also want the pvr binary addon PR merged soon because it blocks pvr development.

smallint · 2015-02-22T09:53:12Z

I picked the fix from @wolfgar and removed the compiler warning. Hope it builds now.

fritsch · 2015-02-22T10:25:15Z

jenkins build this please

wolfgar · 2015-02-22T22:35:25Z

seems the build issue is unrelated to this commit so we may be fine ?

MartijnKaijser · 2015-02-28T22:39:22Z

jenkins build this please

i.MX6 rework which decouples GUI (fb0) and video rendering (fb1), framebuffers are composed with DP in hw

fritsch · 2015-03-01T09:21:54Z

Thanks to everyone involved!

smallint mentioned this pull request Feb 5, 2015

[imx] Deinterlacing rework #5805

Closed

FernetMenta reviewed Feb 6, 2015
View reviewed changes

smallint changed the title ~~i.MX6 rework~~ i.MX6 rework which decouples GUI (fb0) and video rendering (fb1), framebuffers are composed with DP in hw Feb 7, 2015

wolfgar mentioned this pull request Feb 13, 2015

1080i deinterlace issue xbmc-imx6/xbmc#70

Open

piotrasd mentioned this pull request Feb 16, 2015

Add settings for proper working deinterlace on i.MX6 OpenELEC/OpenELEC.tv#3919

Closed

smallint and others added 5 commits February 20, 2015 15:38

[imx] Added de-interlacing method enumerations FAST_MOTION and FAST_M…

23a68fe

…OTION_DOUBLE

[RenderManager] preserve field type for Renderer::RenderUpdate

bf90e31

[imx] Reworked video decoding and rendering, see http://forum.kodi.tv…

a4ab2c2

…/showthread.php?tid=211289&pid=1892440#pid1892440

[iMX6] Implement rendercapture for latest rendering rework

0418c2b

blit fb using g2d when no deinterlacing is required

[imx] Output associated pts for TRACE_FRAMES

1597ced

[imx] Ifdef'd iMX6 specific include

e87adc5

MartijnKaijser added this to the I******* 15.0-alpha2 milestone Feb 22, 2015

wolfgar and others added 2 commits February 22, 2015 09:48

Add guard to fix build on non iMX6 arch

78ad2bf

[imx] Fixed compiler warning

afefdfd

fritsch added a commit that referenced this pull request Mar 1, 2015

Merge pull request #6351 from smallint/imx-rework-pr

645b1c6

i.MX6 rework which decouples GUI (fb0) and video rendering (fb1), framebuffers are composed with DP in hw

fritsch merged commit 645b1c6 into xbmc:master Mar 1, 2015

i.MX6 rework which decouples GUI (fb0) and video rendering (fb1), framebuffers are composed with DP in hw #6351

i.MX6 rework which decouples GUI (fb0) and video rendering (fb1), framebuffers are composed with DP in hw #6351

smallint commented Feb 5, 2015

smallint commented Feb 5, 2015

This comment was marked as spam.

This comment was marked as spam.

FernetMenta commented Feb 6, 2015

fritsch commented Feb 6, 2015

smallint commented Feb 6, 2015

wolfgar commented Feb 7, 2015

koying commented Feb 7, 2015

smallint commented Feb 7, 2015

koying commented Feb 7, 2015

smallint commented Feb 20, 2015

fritsch commented Feb 20, 2015

wolfgar commented Feb 21, 2015

fritsch commented Feb 21, 2015

wolfgar commented Feb 21, 2015

fritsch commented Feb 21, 2015

FernetMenta commented Feb 22, 2015

fritsch commented Feb 22, 2015

MartijnKaijser commented Feb 22, 2015

fritsch commented Feb 22, 2015

FernetMenta commented Feb 22, 2015

smallint commented Feb 22, 2015

fritsch commented Feb 22, 2015

wolfgar commented Feb 22, 2015

MartijnKaijser commented Feb 28, 2015

fritsch commented Mar 1, 2015

		@@ -618,7 +663,6 @@ void CLinuxRendererGLES::FlipPage(int source)
		m_iYV12RenderBuffer = NextYV12Texture();

		m_buffers[m_iYV12RenderBuffer].flipindex = ++m_flipindex;

i.MX6 rework which decouples GUI (fb0) and video rendering (fb1), framebuffers are composed with DP in hw #6351

i.MX6 rework which decouples GUI (fb0) and video rendering (fb1), framebuffers are composed with DP in hw #6351

Conversation

smallint commented Feb 5, 2015

smallint commented Feb 5, 2015

This comment was marked as spam.

This comment was marked as spam.

FernetMenta commented Feb 6, 2015

fritsch commented Feb 6, 2015

smallint commented Feb 6, 2015

wolfgar commented Feb 7, 2015

koying commented Feb 7, 2015

smallint commented Feb 7, 2015

koying commented Feb 7, 2015

smallint commented Feb 20, 2015

fritsch commented Feb 20, 2015

wolfgar commented Feb 21, 2015

fritsch commented Feb 21, 2015

wolfgar commented Feb 21, 2015

fritsch commented Feb 21, 2015

FernetMenta commented Feb 22, 2015

fritsch commented Feb 22, 2015

MartijnKaijser commented Feb 22, 2015

fritsch commented Feb 22, 2015

FernetMenta commented Feb 22, 2015

smallint commented Feb 22, 2015

fritsch commented Feb 22, 2015

wolfgar commented Feb 22, 2015

MartijnKaijser commented Feb 28, 2015

fritsch commented Mar 1, 2015