[pvr] added: attempt to auto-configure pvr clients via avahi #6597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
opdenkamp
added
Type: Feature
opdenkamp
force-pushed
the
autoconfigaddons
branch
from
1607d05
to
7e24fc0
Compare
…vrclient extension point in the addon.xml of the add-on to configure: avahi_type="(avahi type)" avahi_ip_setting="(name of the ip/address setting)" avahi_port_setting="(name of the port setting)"
e.g. for pvr.hts:
<extension
point="xbmc.pvrclient"
avahi_type="_htsp._tcp."
avahi_ip_setting="host"
avahi_port_setting="htsp_port" />
opdenkamp
force-pushed
the
autoconfigaddons
branch
from
7e24fc0
to
7d031ef
Compare
…::RemoveServiceType() public
…tead of sleeping 1 second and then returning
opdenkamp
force-pushed
the
autoconfigaddons
branch
from
7d031ef
to
0889ddf
Compare
|
jenkins build this please |
| /*! | ||
| * @return True if this add-on can be auto-configured via avahi, false otherwise | ||
| */ | ||
| bool CanAutoconfigure(void) const; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
nice addition, makes things lot easier. |
opdenkamp
pushed a commit
that referenced
this pull request
Mar 5, 2015
[pvr] added: attempt to auto-configure pvr clients via avahi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add these to the
xbmc.pvrclientextension point in theaddon.xmlof the add-on to configure:e.g. for pvr.hts (only one that supports avahi afaik):
When the PVR manager is started without any add-ons being enabled, and when disabled add-ons were found with the entries from above in
addon.xml, then it will start the avahi browser, search for the service, and display this dialog:Currently only supports services already included in
CZeroconfBrowser.CZeroconfBrowser::AddServiceType()has to be made public and implemented so services can be added dynamically.And only supports the ip address and port, no username/password.