UPnP: some fixes and improvements #6862
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some odd checks in
CNetworkServices
concerning the different UPnP services (browser, controller, server, renderer) which made it impossible to stop the controller and/or server under certain conditions.When I looked into that code in more detail I noticed that the current code always starts and stops the client/browser and the controller simultaneously and when the controller is disabled in the settings we also can't browse remote UPnP servers. That doesn't make any sense at all. Therefore I split them up and now the client/browser is basically always active so it's always possible to browse remote UPnP servers but the server, controller and renderer are only running if enabled in the settings.