3 patchs :
Retrieve the discnumber when set by a music plugin (it was missing)
The item prefetch fail when playing a music addon item if the stored url is a plugin://
This patch fix this by trying to resolve urls before queuing next track (perhaps it's not the good place but it works...)
When trying to play an item in the musicdb that was scanned from a music addon, it fails (nothing resolve the musicdb://1/2/3/12 url).
this patch add the musicdb urlresolv in the application.cpp probably not the good place but it works.
Thank you !
I'd prefer if 83c7240 was split into 2 (support for plugin:// then support for musicdb:// -> plugin://)
you mean 2 commits, one with only plugin:// and a second one with musicdb://->plugin:// ?
thx to cptspiff i know some rebase magic now, hope it fit :)
Yup, looks good. Will try to find some time to track possible consequences of resolving musicdb:// URLs at play time rather than passing them through the filesystem.
I've looked at a way to add plugin resolv in musicdatabase instead but
there is a pb with CreateCodecDemux when using a plugin item we don't know yet if it will be mp3 or flac or something else... (the standard items use the extention at the end of the musicdb:// url) we could store it too, but its nicer to let the plugin choose.
fix for playing music addons items stored in music database
fix can't set discnumber from a plugin
looks like a dead request... :) should i update the patch for the current master and try a new request ?
It won't be for Frodo either way, so you have plenty of time.
even this simple one : tidalf@9ff3ec2 ? it's more a bugfix than anything else ? :)
Add plugin:// resolving before queueing next track
Resolve musicdb:// before queueing next track
merge from xbmc/xbmc
get thumbnail from plugin when scanning
I've fix the comment on the old tidalf@9ff3ec2 but it will not apply without conflicts on the current master. This one is up to date :
Thanks - will pull it in
just looking at PRs. Was there still something needed for this one or was it already pulled in by you?
I have updated the fix for resolving the musicdb items, its here :
What do you mean by generically (i'd love to help on that one) ?
@tidalf care to update the PR and if possible @jmarshallnz to give some pointers
Fixed: switch to fullscreen when starting a video if music is already…
Related to #688