New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added: also hide thumbs for unwatched episodes if option to show plot is off #6919

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@notspiff
Contributor

notspiff commented Apr 10, 2015

requested in forums at some point. ref @da-anda

@Montellese

This comment has been minimized.

Member

Montellese commented Apr 10, 2015

I don't use the setting so I won't comment on it.

But if we change the behaviour we should probably also change the setting's label and description (and maybe even its identifier).

@notspiff

This comment has been minimized.

Contributor

notspiff commented Apr 10, 2015

absolutely. i just did the intial code so you guys can choose whether to bundle or use another setting.

@da-anda

This comment has been minimized.

Member

da-anda commented Apr 10, 2015

thanks, will test over the weekend. I had bookmarked the commit in your branch but never got to it (just like basic MKA support with the ffmpeg based tagreader).

Might be a good candidate to be tested for side effects on a bigger audience (aside from the settings implementation/naming etc). @MilhouseVH, something for your builds?

@MartijnKaijser

This comment has been minimized.

Member

MartijnKaijser commented Apr 10, 2015

bundled with current setting for hide plot makes most sense. thx :)

@da-anda

This comment has been minimized.

Member

da-anda commented Apr 13, 2015

Thanks @MilhouseVH for adding it to your PI builds. Just tested it and even tough it's working in general, it's not working correctly. In case a TV-show has no watched Episode (or probably also some unwatched episodes) NO artwork for this TV-show will show up anywhere in the skin. No TV-show poster/fanart, no season poster/fanart etc, nothing. So I think there needs to be an explicit check if the current fileItem is a single episode and neither a TV-show or season.

@uNiversaI yep, will be needed, no idea how it should look like (needs to be symbolic and don't contain text)

@un1versal

This comment has been minimized.

Contributor

un1versal commented Apr 13, 2015

I was looking for a better image like one person whispering to another, but so far couldn't find a decent image in public domain... And overlay a glyph of some relevant symbolic type.

Suggestions @ Rought draft to gain perspective on direction http://forum.kodi.tv/showthread.php?tid=130587&pid=1981654#pid1981654 and something more refined @
http://forum.kodi.tv/showthread.php?tid=130587&pid=1982541#pid1982541 all for feedback not useless bikeshedding.

@jjd-uk

This comment has been minimized.

Member

jjd-uk commented Apr 13, 2015

Rather than spam here, let's discuss what DefaultEpisodeHidden.png should be at http://forum.kodi.tv/showthread.php?tid=130587&page=7

@HitcherUK

This comment has been minimized.

Contributor

HitcherUK commented Apr 13, 2015

bundled with current setting for hide plot makes most sense. thx :)

Not if you want to see plots for movies but hide thumbs for episodes though.

IMO it should be a separate option altogether.

@NedScott

This comment has been minimized.

Contributor

NedScott commented Jul 9, 2015

Any change we can merge this as-is for v16? It apparently still works in the @MilhouseVH Pi/OE test builds.

@un1versal

This comment has been minimized.

Contributor

un1versal commented Jul 10, 2015

Any change we can merge this as-is for v16? It apparently still works in the @MilhouseVH Pi/OE test builds.

Its doesn't work very well as it breaks fanart, see #7462 for proper implementation, thx to mkortstiege

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment