New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix playback of YouSee.tv rtsp streams #708

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@twinther
Copy link
Contributor

twinther commented Feb 19, 2012

Hi, this is the pull request for the patch attached on http://trac.xbmc.org/ticket/12516

It fixes playback by using udp instead of tcp. The CSeq expected error is still logged but does not affect playback. However there are artifacts on some streams from time to time, but this is usually "fixed" by restarting the stream.

Br.
Tommy

@elupus

This comment has been minimized.

Copy link
Member

elupus commented Feb 19, 2012

This should be fixed upstream ffmpeg. If it has been fixed there
already, backports of their commits would be much better.

Since it could also break other sources, i'm a bit hesistant unless
it's okeyed upstream.

@twinther

This comment has been minimized.

Copy link
Contributor

twinther commented Feb 19, 2012

okay, I'll talk with upstream.
ffmpeg in xbmc looks to be pretty outdated compared to ffmpeg master though, but the problem is also present there.

@twinther

This comment has been minimized.

Copy link
Contributor

twinther commented Feb 27, 2012

Hi elupus,
I have talked with the ffmpeg guys and a patch has been made. I don't know if it was commit'ed yet to ffmpeg git, but it got the go-ahead on the mailing list:
http://lists.libav.org/pipermail/libav-devel/2012-February/022622.html

I have updated this pull request to include this patch (and reverted the previous changes I made):
http://lists.libav.org/pipermail/libav-devel/2012-February/022485.html

Br.
Tommy

@twinther

This comment has been minimized.

Copy link
Contributor

twinther commented Feb 28, 2012

Hey, the patch is now included in ffmpeg git with commit e3822886ebb3ae97bdae9be264d891f1d35c960b

@elupus

This comment has been minimized.

Copy link
Member

elupus commented Feb 28, 2012

You talked to the libav guys not ffmpeg, but they are similar enough still.
Will look at the patch, but I suspect it will have to wait until after
eden.

@twinther

This comment has been minimized.

Copy link
Contributor

twinther commented Feb 28, 2012

bummer, my YouSee web-tv addon is completely useless without this fix.
It's no fun watching live tv 1 minute at a time :)

@elupus

This comment has been minimized.

Copy link
Member

elupus commented Feb 29, 2012

Ok, so this is a backport of the upstream fix and you've tested it and it works? It looks reasonable.

I would need to verify what other rtsp changes might have gone in to ffmpeg/libav since this change so this doesn't break other streams.

@twinther

This comment has been minimized.

Copy link
Contributor

twinther commented Feb 29, 2012

I applied the patch posted on the mailing list in this pull request. It is my understanding that it was applied as-is in ffmpeg git - and it looks that way as well. I did change one occurrence of ffurl_write() to url_write() though.
I have tested it in xbmc on linux multiple times without any side effects. I actually think the picture quality is better in XBMC (than ffmpeg), but it may just have been the different streams I tested.

I don't think it will affect other streams, because previously the keep-alive request from the server would incorrectly be parsed as a response and thus overwriting values such a seq and session_id and effectively stop the stream.

@twinther

This comment has been minimized.

Copy link
Contributor

twinther commented Mar 26, 2012

Hi elupus, with Eden out the door, do you have an ETA on when this will get pulled?

@elupus

This comment has been minimized.

Copy link
Member

elupus commented Mar 26, 2012

After we got the ffmpeg update merged. Which I'm hoping will be soon.

@twinther

This comment has been minimized.

Copy link
Contributor

twinther commented May 1, 2012

Hi elupus, I see Frodo alpha 1 was tagged - any news on getting this merged?

@twinther

This comment has been minimized.

Copy link
Contributor

twinther commented May 29, 2012

hey, please consider this one for inclusion in June merge window

@twinther

This comment has been minimized.

Copy link
Contributor

twinther commented Jun 25, 2012

Hi @elupus please consider this one for the next merge window.
also please let me know if I need to provide further info/updates.
thanks
Tommy

@twinther

This comment has been minimized.

Copy link
Contributor

twinther commented Jul 17, 2012

Hi @elupus are you getting these comments I'm posting?

@elupus

This comment has been minimized.

Copy link
Member

elupus commented Jul 17, 2012

Yup, but I've apparently forgot about it again. Will try to remember it for
next window.feel free to bump it if I have forgot it by then.

@twinther

This comment has been minimized.

Copy link
Contributor

twinther commented Jul 20, 2012

Sounds great. I see the August milestone is open now, how about just adding it to the list now ;)

@twinther

This comment has been minimized.

Copy link
Contributor

twinther commented Aug 1, 2012

@elupus 1st of the month and a friendly reminder from me :)

@elupus

This comment has been minimized.

Copy link
Member

elupus commented Aug 4, 2012

I'm on vacation for two weeks, will not have computer access. @cptspiff can
you look quickly,then merge?
On Aug 1, 2012 11:13 AM, "Tommy Winther" <
reply@reply.github.com>
wrote:

@elupus 1st of the month and a friendly reminder from me :)


Reply to this email directly or view it on GitHub:
#708 (comment)

@ghost

This comment has been minimized.

Copy link

ghost commented Aug 4, 2012

done in b5cf00a

@ghost ghost closed this Aug 4, 2012

@elupus

This comment has been minimized.

Copy link
Member

elupus commented Aug 4, 2012

Thanks!
On Aug 4, 2012 7:05 PM, "Arne Morten Kvarving" <
reply@reply.github.com>
wrote:

done in b5cf00a


Reply to this email directly or view it on GitHub:
#708 (comment)

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment