Add the option the eject the CD after ripping is down(full disc only) #718

Merged
1 commit merged into from Mar 30, 2012

Projects

None yet

2 participants

@Giftie
Contributor
Giftie commented Feb 22, 2012

This PR adds the option to automatically Eject the CD when a full disc rip has completed.

Used to be part of my other PR(auto rip) but I figured that since it is a separate feature I should split them up.

@jmarshallnz
Member

Seems fine assuming the string is OK'd.

@Giftie
Contributor
Giftie commented Mar 26, 2012

Fixed string and squashed.

@ghost ghost was assigned Mar 26, 2012
@ghost
ghost commented Mar 27, 2012

since i'm a lazy bugger.... on by default please and this looong winding story will have a happy ending :)

@Giftie xbmc Add the option the eject the CD after ripping is down(full disc only)
	modified:   language/English/strings.xml
	modified:   xbmc/cdrip/CDDARipper.cpp
	modified:   xbmc/settings/GUISettings.cpp
Changed string
	modified:   language/English/strings.xml

set default to on
	modified:   xbmc/settings/GUISettings.cpp
b67b921
@Giftie
Contributor
Giftie commented Mar 27, 2012

Changed to default to true.

@ghost ghost merged commit ec949e6 into xbmc:master Mar 30, 2012
@tru tru added a commit to plexinc/plex-home-theater-public that referenced this pull request Nov 12, 2013
@tru tru Refactor search window.
Fixes #741
Fixes #718
0d0db4b
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment