New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup kai toast icons #7183

Merged
merged 2 commits into from Jul 4, 2015

Conversation

Projects
None yet
5 participants
@tamland
Member

tamland commented May 24, 2015

@mkortstiege while we're at it, I don't see why this has to be so complicated.

This replaces control 403, 404 and 405 with the predefined names DefaultIconError.png, DefaultIconWarning.png and DefaultIconInfo.png as we already do with other images.

Is there any reason these controls exist other than for skins to define the image name?

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented May 24, 2015

I can't imagine a reason. @BigNoid, @ronie objections?

@BigNoid

This comment has been minimized.

Member

BigNoid commented May 24, 2015

Afaik everybody uses this to load those default icons, so this is much better. Also nice that DefaultIconInfo.png is now loaded as image if there's no icon.

@ronie

This comment has been minimized.

Member

ronie commented May 25, 2015

nice, +1 from me.

@MartijnKaijser MartijnKaijser added this to the Isengard 16.0-alpha1 milestone Jul 3, 2015

@MartijnKaijser

This comment has been minimized.

Member

MartijnKaijser commented Jul 3, 2015

jenkins build this please

MartijnKaijser added a commit that referenced this pull request Jul 4, 2015

@MartijnKaijser MartijnKaijser merged commit 1ecf2e5 into xbmc:master Jul 4, 2015

1 check passed

default Merged build finished.
Details

@tamland tamland deleted the tamland:toast-icon-cleanup branch Aug 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment