Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[guilib] use textcolor from labelInfo for textboxes #7205

Merged
merged 1 commit into from Jul 8, 2015

Conversation

@mkortstiege
Copy link
Member

mkortstiege commented May 30, 2015

Fixes non-working <textcolor> in textboxes. Reported @ http://forum.kodi.tv/showthread.php?tid=228187

@BigNoid, @ronie for review please. You guys think this is Isengard material?

@BigNoid

This comment has been minimized.

Copy link
Member

BigNoid commented May 30, 2015

Seems like a fix to me as this works for labels too atm. This does break the textcolor when using a format like this: [COLOR FF000000]$INFO[ListItem.Plot][/COLOR]
which worked before in a textbox and still works for label controls inside containers.

@ronie

This comment has been minimized.

Copy link
Member

ronie commented May 30, 2015

if you've found a regression already, it's clear to me this is not isengard material.
as said many times before, don't push last-minute skin engine changes.

@mkortstiege

This comment has been minimized.

Copy link
Member Author

mkortstiege commented May 30, 2015

@BigNoid, thanks for testing. Will see if there's a good way to have both.

@mkortstiege mkortstiege force-pushed the mkortstiege:textbox-textcolor branch from bd9c482 to 5bfeaec Jul 2, 2015
@mkortstiege

This comment has been minimized.

Copy link
Member Author

mkortstiege commented Jul 2, 2015

Updated and rebased.

@mkortstiege

This comment has been minimized.

Copy link
Member Author

mkortstiege commented Jul 3, 2015

Fix confirmed working by @BigNoid.

@mkortstiege

This comment has been minimized.

Copy link
Member Author

mkortstiege commented Jul 4, 2015

Moved to #7384

@mkortstiege mkortstiege force-pushed the mkortstiege:textbox-textcolor branch from 5bfeaec to cbd974a Jul 8, 2015
@mkortstiege

This comment has been minimized.

Copy link
Member Author

mkortstiege commented Jul 8, 2015

Reopened and rebased. jenkins build this please.

mkortstiege added a commit that referenced this pull request Jul 8, 2015
[guilib] use textcolor from labelInfo for textboxes
@mkortstiege mkortstiege merged commit 33ded5c into xbmc:master Jul 8, 2015
1 check failed
1 check failed
default Merged build finished.
Details
@MartijnKaijser MartijnKaijser modified the milestone: Isengard 16.0-alpha1 Jul 8, 2015
@mkortstiege mkortstiege deleted the mkortstiege:textbox-textcolor branch Aug 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.