New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl improvements #7210

Merged
merged 2 commits into from Jul 4, 2015

Conversation

Projects
None yet
4 participants
@arnova
Member

arnova commented May 30, 2015

This PR syncs our select/sleep handling for Curl with upstream. Apparently this never worked properly on at least Windows. Furthermore I added a change where we Sleep between Curl retries as this may increase the chances of a successful recovery in several scenarios (I'm still looking for an optimum here, in case other people have a better idea, please speak up :-)).

@arnova

This comment has been minimized.

Member

arnova commented May 30, 2015

@Paxxi: Please review. jenkins build this please

@arnova

This comment has been minimized.

Member

arnova commented May 31, 2015

jenkins build this please

@Paxxi

This comment has been minimized.

Member

Paxxi commented May 31, 2015

@arnova Have you seen an issue this fixes? I havent noticed any trouble with this piece of code during testing.

@arnova

This comment has been minimized.

Member

arnova commented May 31, 2015

@Paxxi : Well I haven't seen the select() issue since it mostly concerns Windows but it came from upstream Curl. The issue with no delay for (successive) retries is an issue I've seen several times with certain temporary issues (e.g. WiFi failing momentarely).

@arnova

This comment has been minimized.

Member

arnova commented Jul 3, 2015

Any objections against this?

@Paxxi

This comment has been minimized.

Member

Paxxi commented Jul 4, 2015

No objections from me

@arnova

This comment has been minimized.

Member

arnova commented Jul 4, 2015

jenkins build this please

mkortstiege added a commit that referenced this pull request Jul 4, 2015

@mkortstiege mkortstiege merged commit 7209637 into xbmc:master Jul 4, 2015

1 check passed

default Merged build finished.
Details

@MartijnKaijser MartijnKaijser modified the milestone: Isengard 16.0-alpha1 Jul 5, 2015

@arnova arnova deleted the arnova:curl_select branch Jan 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment