New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Confluence hooks for TvTunes v5.0.0 (Simplification) #7315

Merged
merged 2 commits into from Jul 2, 2015

Conversation

Projects
None yet
3 participants
@robwebset
Contributor

robwebset commented Jun 21, 2015

This pull requests makes use of changes in TvTunes v5.0 onwards.

The key change is that it removes the need for the Confluence skin to call TvTunes via the onLoad on some of the windows.

The second change is to change where the skin checks "TvTunesIsAlive" to a more generic "PlayingBackgroundMedia" - this means that any addon that plays media in the background should be able to make use of this, and it isn't specifically designed for TvTunes.

I know that there is a preference by some people to remove some of the links between confluence and TvTunes - this should go a very large way toward that.

@robwebset robwebset changed the title from Updage Confluence hooks for TvTunes v5.0.0 (Simplification) to Update Confluence hooks for TvTunes v5.0.0 (Simplification) Jun 21, 2015

@ronie

This comment has been minimized.

Member

ronie commented Jun 22, 2015

no problem to add the RunScript changes, though it's not quite clear what your plans are with the Window Property.

do you plan to support both for the period of one Kodi release in order to provide backward compatibility for skins?

@robwebset

This comment has been minimized.

Contributor

robwebset commented Jun 22, 2015

Yes, you are correct Ronie - TvTunes will set both TvTunesIsAlive and PlayingBackgroundMedia for the time-being. I remember previous discussions (Last times I changed the TvTunes hooks) where people wanted the reference to TvTunes kept to a minimum.

@ronie

This comment has been minimized.

Member

ronie commented Jun 22, 2015

ok, please submit an updated version to the addon repo first.
once it's pulled, we can merge this PR.

@robwebset

This comment has been minimized.

Contributor

robwebset commented Jun 22, 2015

Thanks, I had one waiting - but didn't want to submit it until it was getting the go-ahead

@ronie

This comment has been minimized.

Member

ronie commented Jun 22, 2015

while your at it, mind using IsEmpty(Window(videolibrary).Property(PlayingBackgroundMedia)) as a visible condition?
it's much cleaner (needs less processing) than a substring compare.

@robwebset

This comment has been minimized.

Contributor

robwebset commented Jun 22, 2015

Sounds like a good idea - I originally followed what was already there - but if this is a better way of doing it, then now is a good time to change, should now be done.

ronie added a commit that referenced this pull request Jul 2, 2015

Merge pull request #7315 from robwebset/TvTunesSimplification
Update Confluence hooks for TvTunes v5.0.0 (Simplification)

@ronie ronie merged commit 3693a0d into xbmc:master Jul 2, 2015

@ronie

This comment has been minimized.

Member

ronie commented Jul 2, 2015

thx!

@robwebset robwebset deleted the robwebset:TvTunesSimplification branch Jul 2, 2015

@MartijnKaijser MartijnKaijser modified the milestone: Isengard 16.0-alpha1 Jul 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment