New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[guilib] auto-width for button controls #7357

Merged
merged 3 commits into from Jul 16, 2015

Conversation

Projects
None yet
6 participants
@mkortstiege
Member

mkortstiege commented Jun 28, 2015

This adds auto-width for button controls. Needs some testing.

@phil65

This comment has been minimized.

Member

phil65 commented Jun 28, 2015

Skinners will love you for this :)
Thx!

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jun 28, 2015

Added a commit that enables auto-width for togglebutton controls

@phil65

This comment has been minimized.

Member

phil65 commented Jun 28, 2015

@HitcherUK mind givin this a shot?

@HitcherUK

This comment has been minimized.

Contributor

HitcherUK commented Jun 28, 2015

Downloading now, will report back later.

PS Many thanks. ;)

@HitcherUK

This comment has been minimized.

Contributor

HitcherUK commented Jun 28, 2015

@mkortstiege Looking good so far except for strings with line breaks in them as seen here for Artwork[CR]Downloader

image

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jun 29, 2015

@HitcherUK, works for me. Mind sharing the skin xml so i can test it?

@HitcherUK

This comment has been minimized.

Contributor

HitcherUK commented Jun 29, 2015

@mkortstiege Here you go -

DialogVideoInfo.xml

http://pastebin.com/rnVGUKsY

I've moved the strings from the language file so you can see them properly. It seems to widen the button more than the others but not enough.

Thanks.

PS The first button is a toggle in case you were wondering why it's different from the rest.

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jun 29, 2015

Updated and rebased. @HitcherUK, new test build is triggered and should be ready in ~1h.

@HitcherUK

This comment has been minimized.

Contributor

HitcherUK commented Jun 29, 2015

@mkortstiege Fixed the textoffsetx problem but there's a slight problem with the togglebutton.

Default label -

screeshot

Alt label -

screenshot

The <altlabel>...</altlabel> seems to be using the width of the <label>...</label> when it comes to spacing in the grouplist.

Test code - http://pastebin.com/eM50ykq9

Browse to a TV show and press info.

Thanks.

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jul 4, 2015

Will be part of #7384

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jul 8, 2015

Reopened and rebased. jenkins build this please

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jul 8, 2015

Added wrapline for button controls commit.

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jul 11, 2015

Rebased. @BigNoid, @HitcherUK, @phil65 and @ronie would be cool if you guys could give this one a try.

@HitcherUK

This comment has been minimized.

Contributor

HitcherUK commented Jul 11, 2015

@mkortstiege could you provide a build for testing please? If not, I'll give me a day or so and I'll do my own.
Thanks.

@MartijnKaijser

This comment has been minimized.

Member

MartijnKaijser commented Jul 11, 2015

@HitcherUK it will be in the usual place in an hour or so with branch name in the filename

@HitcherUK

This comment has been minimized.

Contributor

HitcherUK commented Jul 12, 2015

Look good, thanks.

@MartijnKaijser MartijnKaijser added this to the J**** 16.0-alpha1 milestone Jul 12, 2015

@MartijnKaijser

This comment has been minimized.

Member

MartijnKaijser commented Jul 12, 2015

jenkins build this please

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jul 14, 2015

Anyone tested this? Objections?

@ronie

This comment has been minimized.

Member

ronie commented Jul 15, 2015

works ok as far as i can see.
good to go imo.

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jul 16, 2015

jenkins build and merge

@jenkins4kodi jenkins4kodi merged commit 2599007 into xbmc:master Jul 16, 2015

1 check was pending

default Merged build started.
Details
@HitcherUK

This comment has been minimized.

Contributor

HitcherUK commented Jul 21, 2015

@mkortstiege I've started to add this properly for Jenkins and came across this problem.

When using variable labels the size doesn't change when the condition does.

screenshot000

screenshot001

Thanks.

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jul 24, 2015

Will see if i can get it fixed this weekend.

@HitcherUK

This comment has been minimized.

Contributor

HitcherUK commented Jul 24, 2015

Thanks. Let me know if you need any test code.

@mkortstiege mkortstiege deleted the mkortstiege:button-auto-width branch Aug 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment