Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added: ability to open the smartplaylisteditor for a given playlist #7360

Merged
merged 1 commit into from Jul 5, 2015

Conversation

Projects
None yet
7 participants
@Montellese
Copy link
Member

commented Jun 28, 2015

This is a copy of @notspiff's work from #6966 and allows to open the smartplaylist editor for a specific smartplaylist through builtins.

@@ -31,6 +31,7 @@
#include "FileItem.h"
#include "input/Key.h"
#include "guilib/LocalizeStrings.h"
#include "utils/log.h"

This comment has been minimized.

Copy link
@garbear

garbear Jun 30, 2015

Member

left over from testing? i don't see CLog in use in this file

This comment has been minimized.

Copy link
@Montellese

Montellese Jun 30, 2015

Author Member

You're right. Thanks.

@Montellese Montellese force-pushed the Montellese:xsp_editor_open branch from 6e4e18d to d990cf0 Jun 30, 2015

@Montellese

This comment has been minimized.

Copy link
Member Author

commented Jun 30, 2015

jenkins build this please

@Montellese

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2015

Only some binary addons that failed to build.

@MartijnKaijser MartijnKaijser added this to the Isengard 16.0-alpha1 milestone Jul 4, 2015

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Jul 4, 2015

jenkins build this please

mkortstiege added a commit that referenced this pull request Jul 5, 2015

Merge pull request #7360 from Montellese/xsp_editor_open
added: ability to open the smartplaylisteditor for a given playlist

@mkortstiege mkortstiege merged commit d4e7869 into xbmc:master Jul 5, 2015

1 check passed

default Merged build finished.
Details

@Montellese Montellese deleted the Montellese:xsp_editor_open branch Jul 5, 2015

@Lunatixz

This comment has been minimized.

Copy link

commented Sep 29, 2015

Can someone explain how this works?
ie.
xbmc.executebuiltin( "ActivateWindow(10136,%s)" % xbmc.translatePath(smartplaylist.xsp) )

@Lunatixz

This comment has been minimized.

Copy link

commented Apr 20, 2016

Thanks for adding this to Jarvis... One small problem, if you call xbmc.executebuiltin( "ActivateWindow(10136,%s)" % xbmc.translatePath(smartplaylist.xsp) ) twice, the previous playlist rules are still displayed in the editor, but are not written to the xsp. Only the "find items where" window keeps remanent info, all other properties change between playlists.

@phil65

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

We´re aware of it: #9545
Didnt find the time to look into it again yet though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.