New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[guilib] fixes and additions #7384

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@mkortstiege
Member

mkortstiege commented Jul 2, 2015

Make fadelabels read the scroll tag. Report @ http://forum.kodi.tv/showthread.php?tid=224545

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jul 2, 2015

/cc @BigNoid, @ronie, @tamland. This time with the proposed fix and api bump.

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jul 4, 2015

Ping. jenkins build this please

// check whether or not a scroll tag was specified.
if (scrollValue != CGUIControl::FOCUS)
((CGUIFadeLabelControl *)control)->SetScrolling(scrollValue == CGUIControl::ALWAYS ? true : false);

This comment has been minimized.

@tamland

tamland Jul 4, 2015

Member

No need for the ?: part. scrollValue == CGUIControl::ALWAYS evaluates to exactly that

@tamland

This comment has been minimized.

Member

tamland commented Jul 4, 2015

All good on the api bumping side;)

@MartijnKaijser

This comment has been minimized.

Member

MartijnKaijser commented Jul 4, 2015

should gui also have an api bump?

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jul 4, 2015

should gui also have an api bump?

@ronie ?

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jul 4, 2015

Addressed @tamland's comment and added the gui api bump.

@MartijnKaijser MartijnKaijser added this to the Isengard 16.0-alpha1 milestone Jul 4, 2015

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jul 4, 2015

Please don't merge yet. I'll add other guilib related commits so we can avoid all the api version bumping.

@mkortstiege mkortstiege added the WIP label Jul 4, 2015

@mkortstiege mkortstiege changed the title from [guilib] fadelabel not reading scroll tag to [guilib] fixes and additions Jul 4, 2015

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jul 5, 2015

jenkins build this please.

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jul 6, 2015

jenkins build this please

@ronie

This comment has been minimized.

Member

ronie commented Jul 8, 2015

fwitw i'd rather prefer separate PR's instead of lumping them all together.
if this is done just to make gui bumps easier, then we'll have to come up with a better way to handle them.

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jul 8, 2015

@ronie, ok will split them up again (later today).

@mkortstiege

This comment has been minimized.

Member

mkortstiege commented Jul 8, 2015

Splitted em up in separate PRs.

@mkortstiege mkortstiege closed this Jul 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment