New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rbp] Some improvements with display resolution probing #7394

Merged
merged 5 commits into from Jul 4, 2015

Conversation

Projects
None yet
4 participants
@popcornmix
Member

popcornmix commented Jul 3, 2015

Some patches from newclock4 branch. The @macrules ones are from #2610 which was abandoned but they unify the composite/hdmi code, so it's worth using.

Explicitly adding the desktop resolution to list of supported modes is a bug fix for users with a display that supports 1080i but not 1080p.

popcornmix and others added some commits Sep 9, 2014

Changed SDTV resolutions to be treated similarly to HDMI resolutions …
…in SetNativeResolution. This means that the SDTV interface is powered up and set to the right mode.
[rpi] Always add desktop resolution to supported list
There was an assumption that the desktop resolution would be in the probed list, but that is sometimes not the case.
We don't add interlaced resolutions to list, but they can be the preferred resolution read from edid. See:
http://openelec.tv/forum/124-raspberry-pi/77074-forcing-interlaced-output

Also hotplug changes causing an edid reread may cause the supported modes to change (e.g. powering on receiver)
and it is possible the previous preferred mode is no longer there

So ensure that desktop resolution is always added to list. Also handle the case where desktop resolution is invalid on launch
(e.g. hdmi output powered off)
@popcornmix

This comment has been minimized.

Member

popcornmix commented Jul 3, 2015

jenkins build this please

@popcornmix

This comment has been minimized.

Member

popcornmix commented Jul 4, 2015

OSX build fail unrelated.

popcornmix added a commit that referenced this pull request Jul 4, 2015

Merge pull request #7394 from popcornmix/rbp_egl
[rbp] Some improvements with display resolution probing

@popcornmix popcornmix merged commit 0c75393 into xbmc:master Jul 4, 2015

1 check failed

default Merged build finished.
Details

@popcornmix popcornmix deleted the popcornmix:rbp_egl branch Jul 4, 2015

@hudokkow hudokkow added this to the Isengard 16.0-alpha1 milestone Jul 4, 2015

@Razzeee Razzeee added the RPi label Dec 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment