New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodecScreen: Remove fps #7406

Merged
merged 2 commits into from Jul 5, 2015

Conversation

Projects
None yet
7 participants
@fritsch
Member

fritsch commented Jul 4, 2015

Having enough from all those pseudos on the forum, that don't understand what fps really means ... here it goes away.

@FernetMenta

This comment has been minimized.

Member

FernetMenta commented Jul 4, 2015

hehe +1
better late than never :)

@arnova

This comment has been minimized.

Member

arnova commented Jul 4, 2015

Isn't this still useful for debugging purposes?

@fritsch

This comment has been minimized.

Member

fritsch commented Jul 4, 2015

@arnova What exactly do you want to debug? This fps value is an incorrect value on all Bypass render arches it will show something like 7 fps ... all the time. On "standard" systems it's an incorrect value, that is ~ +-3 fps near the real value.

And to add: it has nothing to do with the swapBuffers we are doing to get decoded surface onto the screen.

@afedchin

This comment has been minimized.

Member

afedchin commented Jul 4, 2015

for debugging you can use ToggleDebug

@afedchin

This comment has been minimized.

Member

afedchin commented Jul 4, 2015

but I predict shit storm from users who uses this as fps meter.

@arnova

This comment has been minimized.

Member

arnova commented Jul 4, 2015

I see, then it's pretty useless yes.

@fritsch

This comment has been minimized.

Member

fritsch commented Jul 4, 2015

@afedchin Basically I removed it cause of the "current" shitstorm ...

  • my fps values are 24.9 but I play 23.976 fps
  • my fps sticks at 7.5 fps - I had to downgrade to v14
  • Kodi v15 runs slow on my system
  • ...

Even the wiki entry did not help: http://kodi.wiki/view/Codecinfo <- that was most likely fernet and that ws me in order to inform users: http://kodi.wiki/view/Kodi_v15_(Isengard)_FAQ#The_.22o.22_screen_doesn.27t_show_the_video_FPS_anymore

@afedchin

This comment has been minimized.

Member

afedchin commented Jul 4, 2015

@fritsch let's see which storm is stronger :)
+1 from me to merge this

@FernetMenta

This comment has been minimized.

Member

FernetMenta commented Jul 4, 2015

Isn't this still useful for debugging purposes?

@arnova why do you think so? it turned out that I was the only person on earth who knew what exactly this value is about. how can someone use something for debugging without knowing what exactly it shows?

@un1versal

This comment has been minimized.

Contributor

un1versal commented Jul 4, 2015

The only value that should replace this is total/free memory since that line already displays cpu usage that at least is useful

@MartijnKaijser

This comment has been minimized.

Member

MartijnKaijser commented Jul 4, 2015

please backport to Isengard as well and remove from systeminfo too

@Paxxi

This comment has been minimized.

Member

Paxxi commented Jul 4, 2015

+1 it's about time this goes away

@fritsch

This comment has been minimized.

Member

fritsch commented Jul 5, 2015

Updated.

@MartijnKaijser

This comment has been minimized.

Member

MartijnKaijser commented Jul 5, 2015

jenkins build this please

@MartijnKaijser MartijnKaijser added this to the Isengard 16.0-alpha1 milestone Jul 5, 2015

MartijnKaijser added a commit that referenced this pull request Jul 5, 2015

@MartijnKaijser MartijnKaijser merged commit 333bd8f into xbmc:master Jul 5, 2015

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment