Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutorunMediaJob] make hardcoded strings translatable #7426

Merged
merged 1 commit into from Jul 8, 2015

Conversation

@un1versal
Copy link
Contributor

un1versal commented Jul 6, 2015

Like title says.

@Paxxi knows. :)

@ksooo

This comment has been minimized.

Copy link
Member

ksooo commented Jul 6, 2015

@uNiversaI Thx, this one was bugging me for a long time.

@MartijnKaijser

This comment has been minimized.

Copy link
Member

MartijnKaijser commented Jul 6, 2015

should be backported as well

@@ -11432,7 +11432,30 @@ msgctxt "#21330"
msgid "Show hidden files and directories"
msgstr ""

#empty strings from id 21331 to 21335
#: xbmc/storage/AutorunMediaJob.cpp

This comment has been minimized.

Copy link
@da-anda

da-anda Jul 6, 2015

Member

mind adding contextual help strings?

This comment has been minimized.

Copy link
@un1versal

un1versal Jul 6, 2015

Author Contributor

I do mind, they dont belong here I dont think, its not that type of dialog.
This is a pop up when you plug in/insert external media like a cd/dvd

This comment has been minimized.

Copy link
@da-anda

da-anda Jul 6, 2015

Member

still strings could be reused by devs in future and thus a contextual comment would help. It also helps translators to know if a string is f.e. a dialog headline, message text or a settings value (f.e. to adjust length of translation)

@da-anda

This comment has been minimized.

Copy link
Member

da-anda commented Jul 6, 2015

I've never seen this dialog - how to trigger? It didn't show up when I plugged a USB-Stick or HDD. I'm asking because I think the dialog might look a bit cryptic and could probably need a little more text, like "what would you like to do?"

@un1versal

This comment has been minimized.

Copy link
Contributor Author

un1versal commented Jul 6, 2015

Its shows up when you insert optical media here for instance. HDD/USB doesnt seem to trigger this for some reason, but it should imo. I cant fix or extend that anyway and it should be done in some other PR by someone who can do that bit.

Correction, Somehow in master this is broken and doesnt trigger anymore for me with media that use to trigger it here. I was just trying to get a screenshot.

@da-anda

This comment has been minimized.

Copy link
Member

da-anda commented Jul 6, 2015

it's not triggered on Windows when I insert a CD with pictures. All I get is "Play disc" showing up in the main menu, which is totally wrong for this particular disc. I don't even get the kaitoast when un-/plugging USB media like I do on OpenElec. Can somebody on Windows confirm that nothing at all is happening, or is it just my test setup?

@un1versal

This comment has been minimized.

Copy link
Contributor Author

un1versal commented Jul 6, 2015

Yea even the kaytoasts is all messed up here in Linux, on CD/insert it says I "inserted removable hard drive" its a (internal CD/DVD not usb). No surprise there for me all external media handling most notably optical media has barely worked so far.

@un1versal un1versal force-pushed the un1versal:translate branch from 7aa17b6 to d263790 Jul 6, 2015
@un1versal un1versal force-pushed the un1versal:translate branch from d263790 to 7e9b77a Jul 6, 2015
@MartijnKaijser MartijnKaijser added this to the Isengard 16.0-alpha1 milestone Jul 8, 2015
@MartijnKaijser

This comment has been minimized.

Copy link
Member

MartijnKaijser commented Jul 8, 2015

jenkins build and merge

MartijnKaijser added a commit that referenced this pull request Jul 8, 2015
[AutorunMediaJob] make hardcoded strings translatable
@MartijnKaijser MartijnKaijser merged commit d0fff17 into xbmc:master Jul 8, 2015
1 check failed
1 check failed
default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.