Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[AutorunMediaJob] make hardcoded strings translatable #7426
Conversation
This comment has been minimized.
This comment has been minimized.
@uNiversaI Thx, this one was bugging me for a long time. |
This comment has been minimized.
This comment has been minimized.
should be backported as well |
@@ -11432,7 +11432,30 @@ msgctxt "#21330" | |||
msgid "Show hidden files and directories" | |||
msgstr "" | |||
|
|||
#empty strings from id 21331 to 21335 | |||
#: xbmc/storage/AutorunMediaJob.cpp |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
un1versal
Jul 6, 2015
Author
Contributor
I do mind, they dont belong here I dont think, its not that type of dialog.
This is a pop up when you plug in/insert external media like a cd/dvd
This comment has been minimized.
This comment has been minimized.
da-anda
Jul 6, 2015
Member
still strings could be reused by devs in future and thus a contextual comment would help. It also helps translators to know if a string is f.e. a dialog headline, message text or a settings value (f.e. to adjust length of translation)
This comment has been minimized.
This comment has been minimized.
I've never seen this dialog - how to trigger? It didn't show up when I plugged a USB-Stick or HDD. I'm asking because I think the dialog might look a bit cryptic and could probably need a little more text, like "what would you like to do?" |
This comment has been minimized.
This comment has been minimized.
Correction, Somehow in master this is broken and doesnt trigger anymore for me with media that use to trigger it here. I was just trying to get a screenshot. |
This comment has been minimized.
This comment has been minimized.
it's not triggered on Windows when I insert a CD with pictures. All I get is "Play disc" showing up in the main menu, which is totally wrong for this particular disc. I don't even get the kaitoast when un-/plugging USB media like I do on OpenElec. Can somebody on Windows confirm that nothing at all is happening, or is it just my test setup? |
This comment has been minimized.
This comment has been minimized.
Yea even the kaytoasts is all messed up here in Linux, on CD/insert it says I "inserted removable hard drive" its a (internal CD/DVD not usb). No surprise there for me all external media handling most notably optical media has barely worked so far. |
This comment has been minimized.
This comment has been minimized.
jenkins build and merge |
[AutorunMediaJob] make hardcoded strings translatable
un1versal commentedJul 6, 2015
Like title says.
@Paxxi knows. :)