Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

VolumeUp/VolumeDown buttons in video and music OSD #764

Closed
wants to merge 2 commits into from

6 participants

Max Auer jmarshallnz Jezz Damian Huckle Memphiz da-anda
Max Auer

This set of commits adds volume control to video and music osd...
credits to DJToll for the buttons :-D
For further information see here:
http://trac.xbmc.org/ticket/12794

mad-max

jmarshallnz
Owner

Wouldn't a slider be nicer than an up/down button?

Jezz
Collaborator

I don't really like it :( maybe it's just a personal thing but i don't see a need to include it. Do we really need to have the buttons just because we can? Can't people just push the buttons our turn the dial

Max Auer

@jmarshallnz
I wouldn't have a problem to include it as slider...I thought about buttons because I don't own an ATV and I'm not familiar with the apple remote...So I was unsure if this would really increase the usability...
Buttons always work...

@JezzX
As I said before, I'm not familiar with the Apple remote and it seemed a good way to more usability/user friendlyness...
IMHO this is also not needed for me, but I saw more than a dozen requests in skin specific and confluence forums...

mad-max

Damian Huckle
Collaborator

No ATV here, but can confirm this is currently not user-friendly for ATV / Apple Remote users if you guys can agree on best methods.

Jezz
Collaborator

you can't even currently control the volume on iOS last a checked so the buttons would do nothing on the atv anyway

Max Auer

That's a good point...didn't know that...so it won't be more userfriendly...
At least for iOS, what was my intention...
The more I think about jmarshall's suggestion with the slider the more I like it...
I think this is the way to go...will redo the stuff with a slider and see how it behaves...
Maybe it's the better attempt...

Memphiz
Owner

Well there is a pr in queue which adds repeated remote key presses (talking about atv2 though - no clue about atv1) ... at least for video playback one just needs to push and hold up/down then to change the volume. Pretty easy imho (should work in music fullscreen too i think).

Jezz JezzX was assigned
Max Auer

Sorry Memphiz, but this comment confused my a bit...
The PR you mention is for repeated keypress from the Apple Remote which would make this PR obsolete
OR
The PR you mention give the general ability for repeated keypress from the Apple Remote which would lead to the fact that the buttons are fine and no slider is needed?
OR
Maybe I'm too dumb to read :-D

mad-max

Memphiz
Owner

nvm ... maybe i just got this whole pr wrong. I just wanted to say that with my pr the volume during fullscreen video playback can be changed by holding button up/down on the appletv2 remote ...

Max Auer

Ah ok, so the first option...from point of usability my PR is obsolete, at least for ATV.
As the intention was to have this for the ATV I leave the decisions to the Devs whether this PR will get closed, pulled or shall be modified to have a slider...

da-anda
Collaborator

IMO the buttons are bad. Way to much button overhead already. And next thing to come would be a additional mute button. If we go for buttons (f.e. for touch devices without hw volume buttons) we would need to find some other solution.

jmarshallnz
Owner

For touch we'd just have a volume slider which is far more intuitive + quick to use.

Either way, it looks like this PR is not going to be going in.

Tobias Hieta tru referenced this pull request from a commit in plexinc/plex-home-theater-public
Tobias Hieta tru Fix primaryFilterActivated
Fixes #764
c376627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
64 addons/skin.confluence/720p/MusicOSD.xml
View
@@ -145,72 +145,102 @@
<posy>0</posy>
<width>45</width>
<height>45</height>
+ <label>209</label>
+ <font>-</font>
+ <texturefocus>OSDVolDownFO.png</texturefocus>
+ <texturenofocus>OSDVolDownNF.png</texturenofocus>
+ <onleft>605</onleft>
+ <onright>607</onright>
+ <onup>1000</onup>
+ <ondown>1000</ondown>
+ <onclick>VolumeDown</onclick>
+ </control>
+ <control type="button" id="607">
+ <posx>315</posx>
+ <posy>0</posy>
+ <width>45</width>
+ <height>45</height>
+ <label>209</label>
+ <font>-</font>
+ <texturefocus>OSDVolUpFO.png</texturefocus>
+ <texturenofocus>OSDVolUpNF.png</texturenofocus>
+ <onleft>606</onleft>
+ <onright>608</onright>
+ <onup>1000</onup>
+ <ondown>1000</ondown>
+ <onclick>VolumeUp</onclick>
+ </control>
+ <control type="button" id="608">
+ <posx>360</posx>
+ <posy>0</posy>
+ <width>45</width>
+ <height>45</height>
<label>$LOCALIZE[486]$INFO[Playlist.Repeat, : ]</label>
<font>-</font>
<texturefocus>-</texturefocus>
<texturenofocus>-</texturenofocus>
<onclick>XBMC.PlayerControl(Repeat)</onclick>
- <onleft>605</onleft>
- <onright>607</onright>
+ <onleft>607</onleft>
+ <onright>609</onright>
<onup>1000</onup>
<ondown>1000</ondown>
</control>
<control type="image">
- <posx>270</posx>
+ <posx>360</posx>
<posy>0</posy>
<width>45</width>
<height>45</height>
<texture>OSDRepeatNF.png</texture>
<visible>!Playlist.IsRepeat + !Playlist.IsRepeatOne</visible>
- <visible>!Control.HasFocus(606)</visible>
+ <visible>!Control.HasFocus(608)</visible>
</control>
<control type="image">
- <posx>270</posx>
+ <posx>360</posx>
<posy>0</posy>
<width>45</width>
<height>45</height>
<texture>OSDRepeatFO.png</texture>
<visible>!Playlist.IsRepeat + !Playlist.IsRepeatOne</visible>
- <visible>Control.HasFocus(606)</visible>
+ <visible>Control.HasFocus(608)</visible>
</control>
<control type="image">
- <posx>270</posx>
+ <posx>360</posx>
<posy>0</posy>
<width>45</width>
<height>45</height>
<texture>OSDRepeatOneNF.png</texture>
<visible>Playlist.IsRepeatOne</visible>
- <visible>!Control.HasFocus(606)</visible>
+ <visible>!Control.HasFocus(608)</visible>
</control>
<control type="image">
- <posx>270</posx>
+ <posx>360</posx>
<posy>0</posy>
<width>45</width>
<height>45</height>
<texture>OSDRepeatOneFO.png</texture>
<visible>Playlist.IsRepeatOne</visible>
- <visible>Control.HasFocus(606)</visible>
+ <visible>Control.HasFocus(608)</visible>
</control>
<control type="image">
- <posx>270</posx>
+ <posx>360</posx>
<posy>0</posy>
<width>45</width>
<height>45</height>
<texture>OSDRepeatAllNF.png</texture>
<visible>Playlist.IsRepeat</visible>
- <visible>!Control.HasFocus(606)</visible>
+ <visible>!Control.HasFocus(608)</visible>
</control>
<control type="image">
- <posx>270</posx>
+ <posx>360</posx>
<posy>0</posy>
<width>45</width>
<height>45</height>
<texture>OSDRepeatAllFO.png</texture>
<visible>Playlist.IsRepeat</visible>
- <visible>Control.HasFocus(606)</visible>
+ <visible>Control.HasFocus(608)</visible>
</control>
- <control type="togglebutton" id="607">
- <posx>315</posx>
+ <control type="togglebutton" id="609">
+ <posx>405</posx>
<posy>0</posy>
<width>45</width>
<height>45</height>
@@ -222,7 +252,7 @@
<alttexturefocus>OSDRandomOnFO.png</alttexturefocus>
<alttexturenofocus>OSDRandomOnNF.png</alttexturenofocus>
<onclick>XBMC.PlayerControl(Random)</onclick>
- <onleft>606</onleft>
+ <onleft>608</onleft>
<onright>701</onright>
<onup>1000</onup>
<ondown>1000</ondown>
34 addons/skin.confluence/720p/VideoOSD.xml
View
@@ -135,11 +135,41 @@
<texturefocus>OSDNextTrackFO.png</texturefocus>
<texturenofocus>OSDNextTrackNF.png</texturenofocus>
<onleft>604</onleft>
- <onright>701</onright>
+ <onright>606</onright>
<onup>1000</onup>
<ondown>1000</ondown>
<onclick>PlayerControl(Next)</onclick>
</control>
+ <control type="button" id="606">
+ <posx>270</posx>
+ <posy>0</posy>
+ <width>45</width>
+ <height>45</height>
+ <label>209</label>
+ <font>-</font>
+ <texturefocus>OSDVolDownFO.png</texturefocus>
+ <texturenofocus>OSDVolDownNF.png</texturenofocus>
+ <onleft>605</onleft>
+ <onright>607</onright>
+ <onup>1000</onup>
+ <ondown>1000</ondown>
+ <onclick>VolumeDown</onclick>
+ </control>
+ <control type="button" id="607">
+ <posx>315</posx>
+ <posy>0</posy>
+ <width>45</width>
+ <height>45</height>
+ <label>209</label>
+ <font>-</font>
+ <texturefocus>OSDVolUpFO.png</texturefocus>
+ <texturenofocus>OSDVolUpNF.png</texturenofocus>
+ <onleft>606</onleft>
+ <onright>701</onright>
+ <onup>1000</onup>
+ <ondown>1000</ondown>
+ <onclick>VolumeUp</onclick>
+ </control>
</control>
<control type="group">
<posx>250r</posx>
@@ -157,7 +187,7 @@
<texturenofocus>OSDSubtitlesNF.png</texturenofocus>
<alttexturefocus>OSDSubtitlesFO.png</alttexturefocus>
<alttexturenofocus>OSDSubtitlesNF.png</alttexturenofocus>
- <onleft>605</onleft>
+ <onleft>607</onleft>
<onright>702</onright>
<onup>1000</onup>
<ondown>1000</ondown>
BIN  addons/skin.confluence/media/OSDVolDownFO.png
View
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
BIN  addons/skin.confluence/media/OSDVolDownNF.png
View
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
BIN  addons/skin.confluence/media/OSDVolUpFO.png
View
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
BIN  addons/skin.confluence/media/OSDVolUpNF.png
View
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Something went wrong with that request. Please try again.