Skip to content
This repository

VolumeUp/VolumeDown buttons in video and music OSD #764

Closed
wants to merge 2 commits into from

6 participants

Max Auer jmarshallnz Jezz Damian Huckle Memphiz da-anda
Max Auer

This set of commits adds volume control to video and music osd...
credits to DJToll for the buttons :-D
For further information see here:
http://trac.xbmc.org/ticket/12794

mad-max

jmarshallnz
Owner

Wouldn't a slider be nicer than an up/down button?

Jezz
Collaborator
JezzX commented

I don't really like it :( maybe it's just a personal thing but i don't see a need to include it. Do we really need to have the buttons just because we can? Can't people just push the buttons our turn the dial

Max Auer

@jmarshallnz
I wouldn't have a problem to include it as slider...I thought about buttons because I don't own an ATV and I'm not familiar with the apple remote...So I was unsure if this would really increase the usability...
Buttons always work...

@JezzX
As I said before, I'm not familiar with the Apple remote and it seemed a good way to more usability/user friendlyness...
IMHO this is also not needed for me, but I saw more than a dozen requests in skin specific and confluence forums...

mad-max

Damian Huckle
Collaborator

No ATV here, but can confirm this is currently not user-friendly for ATV / Apple Remote users if you guys can agree on best methods.

Jezz
Collaborator
JezzX commented

you can't even currently control the volume on iOS last a checked so the buttons would do nothing on the atv anyway

Max Auer

That's a good point...didn't know that...so it won't be more userfriendly...
At least for iOS, what was my intention...
The more I think about jmarshall's suggestion with the slider the more I like it...
I think this is the way to go...will redo the stuff with a slider and see how it behaves...
Maybe it's the better attempt...

Memphiz
Owner

Well there is a pr in queue which adds repeated remote key presses (talking about atv2 though - no clue about atv1) ... at least for video playback one just needs to push and hold up/down then to change the volume. Pretty easy imho (should work in music fullscreen too i think).

Max Auer

Sorry Memphiz, but this comment confused my a bit...
The PR you mention is for repeated keypress from the Apple Remote which would make this PR obsolete
OR
The PR you mention give the general ability for repeated keypress from the Apple Remote which would lead to the fact that the buttons are fine and no slider is needed?
OR
Maybe I'm too dumb to read :-D

mad-max

Memphiz
Owner

nvm ... maybe i just got this whole pr wrong. I just wanted to say that with my pr the volume during fullscreen video playback can be changed by holding button up/down on the appletv2 remote ...

Max Auer

Ah ok, so the first option...from point of usability my PR is obsolete, at least for ATV.
As the intention was to have this for the ATV I leave the decisions to the Devs whether this PR will get closed, pulled or shall be modified to have a slider...

da-anda
Collaborator

IMO the buttons are bad. Way to much button overhead already. And next thing to come would be a additional mute button. If we go for buttons (f.e. for touch devices without hw volume buttons) we would need to find some other solution.

jmarshallnz
Owner

For touch we'd just have a volume slider which is far more intuitive + quick to use.

Either way, it looks like this PR is not going to be going in.

Tobias Hieta tru referenced this pull request from a commit in plexinc/plex-home-theater-public
Tobias Hieta tru Fix primaryFilterActivated
Fixes #764
c376627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
64 addons/skin.confluence/720p/MusicOSD.xml
@@ -145,72 +145,102 @@
145 145 <posy>0</posy>
146 146 <width>45</width>
147 147 <height>45</height>
  148 + <label>209</label>
  149 + <font>-</font>
  150 + <texturefocus>OSDVolDownFO.png</texturefocus>
  151 + <texturenofocus>OSDVolDownNF.png</texturenofocus>
  152 + <onleft>605</onleft>
  153 + <onright>607</onright>
  154 + <onup>1000</onup>
  155 + <ondown>1000</ondown>
  156 + <onclick>VolumeDown</onclick>
  157 + </control>
  158 + <control type="button" id="607">
  159 + <posx>315</posx>
  160 + <posy>0</posy>
  161 + <width>45</width>
  162 + <height>45</height>
  163 + <label>209</label>
  164 + <font>-</font>
  165 + <texturefocus>OSDVolUpFO.png</texturefocus>
  166 + <texturenofocus>OSDVolUpNF.png</texturenofocus>
  167 + <onleft>606</onleft>
  168 + <onright>608</onright>
  169 + <onup>1000</onup>
  170 + <ondown>1000</ondown>
  171 + <onclick>VolumeUp</onclick>
  172 + </control>
  173 + <control type="button" id="608">
  174 + <posx>360</posx>
  175 + <posy>0</posy>
  176 + <width>45</width>
  177 + <height>45</height>
148 178 <label>$LOCALIZE[486]$INFO[Playlist.Repeat, : ]</label>
149 179 <font>-</font>
150 180 <texturefocus>-</texturefocus>
151 181 <texturenofocus>-</texturenofocus>
152 182 <onclick>XBMC.PlayerControl(Repeat)</onclick>
153   - <onleft>605</onleft>
154   - <onright>607</onright>
  183 + <onleft>607</onleft>
  184 + <onright>609</onright>
155 185 <onup>1000</onup>
156 186 <ondown>1000</ondown>
157 187 </control>
158 188 <control type="image">
159   - <posx>270</posx>
  189 + <posx>360</posx>
160 190 <posy>0</posy>
161 191 <width>45</width>
162 192 <height>45</height>
163 193 <texture>OSDRepeatNF.png</texture>
164 194 <visible>!Playlist.IsRepeat + !Playlist.IsRepeatOne</visible>
165   - <visible>!Control.HasFocus(606)</visible>
  195 + <visible>!Control.HasFocus(608)</visible>
166 196 </control>
167 197 <control type="image">
168   - <posx>270</posx>
  198 + <posx>360</posx>
169 199 <posy>0</posy>
170 200 <width>45</width>
171 201 <height>45</height>
172 202 <texture>OSDRepeatFO.png</texture>
173 203 <visible>!Playlist.IsRepeat + !Playlist.IsRepeatOne</visible>
174   - <visible>Control.HasFocus(606)</visible>
  204 + <visible>Control.HasFocus(608)</visible>
175 205 </control>
176 206 <control type="image">
177   - <posx>270</posx>
  207 + <posx>360</posx>
178 208 <posy>0</posy>
179 209 <width>45</width>
180 210 <height>45</height>
181 211 <texture>OSDRepeatOneNF.png</texture>
182 212 <visible>Playlist.IsRepeatOne</visible>
183   - <visible>!Control.HasFocus(606)</visible>
  213 + <visible>!Control.HasFocus(608)</visible>
184 214 </control>
185 215 <control type="image">
186   - <posx>270</posx>
  216 + <posx>360</posx>
187 217 <posy>0</posy>
188 218 <width>45</width>
189 219 <height>45</height>
190 220 <texture>OSDRepeatOneFO.png</texture>
191 221 <visible>Playlist.IsRepeatOne</visible>
192   - <visible>Control.HasFocus(606)</visible>
  222 + <visible>Control.HasFocus(608)</visible>
193 223 </control>
194 224 <control type="image">
195   - <posx>270</posx>
  225 + <posx>360</posx>
196 226 <posy>0</posy>
197 227 <width>45</width>
198 228 <height>45</height>
199 229 <texture>OSDRepeatAllNF.png</texture>
200 230 <visible>Playlist.IsRepeat</visible>
201   - <visible>!Control.HasFocus(606)</visible>
  231 + <visible>!Control.HasFocus(608)</visible>
202 232 </control>
203 233 <control type="image">
204   - <posx>270</posx>
  234 + <posx>360</posx>
205 235 <posy>0</posy>
206 236 <width>45</width>
207 237 <height>45</height>
208 238 <texture>OSDRepeatAllFO.png</texture>
209 239 <visible>Playlist.IsRepeat</visible>
210   - <visible>Control.HasFocus(606)</visible>
  240 + <visible>Control.HasFocus(608)</visible>
211 241 </control>
212   - <control type="togglebutton" id="607">
213   - <posx>315</posx>
  242 + <control type="togglebutton" id="609">
  243 + <posx>405</posx>
214 244 <posy>0</posy>
215 245 <width>45</width>
216 246 <height>45</height>
@@ -222,7 +252,7 @@
222 252 <alttexturefocus>OSDRandomOnFO.png</alttexturefocus>
223 253 <alttexturenofocus>OSDRandomOnNF.png</alttexturenofocus>
224 254 <onclick>XBMC.PlayerControl(Random)</onclick>
225   - <onleft>606</onleft>
  255 + <onleft>608</onleft>
226 256 <onright>701</onright>
227 257 <onup>1000</onup>
228 258 <ondown>1000</ondown>
34 addons/skin.confluence/720p/VideoOSD.xml
@@ -135,11 +135,41 @@
135 135 <texturefocus>OSDNextTrackFO.png</texturefocus>
136 136 <texturenofocus>OSDNextTrackNF.png</texturenofocus>
137 137 <onleft>604</onleft>
138   - <onright>701</onright>
  138 + <onright>606</onright>
139 139 <onup>1000</onup>
140 140 <ondown>1000</ondown>
141 141 <onclick>PlayerControl(Next)</onclick>
142 142 </control>
  143 + <control type="button" id="606">
  144 + <posx>270</posx>
  145 + <posy>0</posy>
  146 + <width>45</width>
  147 + <height>45</height>
  148 + <label>209</label>
  149 + <font>-</font>
  150 + <texturefocus>OSDVolDownFO.png</texturefocus>
  151 + <texturenofocus>OSDVolDownNF.png</texturenofocus>
  152 + <onleft>605</onleft>
  153 + <onright>607</onright>
  154 + <onup>1000</onup>
  155 + <ondown>1000</ondown>
  156 + <onclick>VolumeDown</onclick>
  157 + </control>
  158 + <control type="button" id="607">
  159 + <posx>315</posx>
  160 + <posy>0</posy>
  161 + <width>45</width>
  162 + <height>45</height>
  163 + <label>209</label>
  164 + <font>-</font>
  165 + <texturefocus>OSDVolUpFO.png</texturefocus>
  166 + <texturenofocus>OSDVolUpNF.png</texturenofocus>
  167 + <onleft>606</onleft>
  168 + <onright>701</onright>
  169 + <onup>1000</onup>
  170 + <ondown>1000</ondown>
  171 + <onclick>VolumeUp</onclick>
  172 + </control>
143 173 </control>
144 174 <control type="group">
145 175 <posx>250r</posx>
@@ -157,7 +187,7 @@
157 187 <texturenofocus>OSDSubtitlesNF.png</texturenofocus>
158 188 <alttexturefocus>OSDSubtitlesFO.png</alttexturefocus>
159 189 <alttexturenofocus>OSDSubtitlesNF.png</alttexturenofocus>
160   - <onleft>605</onleft>
  190 + <onleft>607</onleft>
161 191 <onright>702</onright>
162 192 <onup>1000</onup>
163 193 <ondown>1000</ondown>
BIN  addons/skin.confluence/media/OSDVolDownFO.png
BIN  addons/skin.confluence/media/OSDVolDownNF.png
BIN  addons/skin.confluence/media/OSDVolUpFO.png
BIN  addons/skin.confluence/media/OSDVolUpNF.png

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.