Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[guilib] fix textbox textcolor not properly set #7671
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
Confirmed working. |
This comment has been minimized.
This comment has been minimized.
|
jenkins build this please |
This comment has been minimized.
This comment has been minimized.
|
I can also confirm all variations are working (textcolor and [COLOR] tag, with and without color aliases) |
mkortstiege
added a commit
that referenced
this pull request
Aug 1, 2015
[guilib] fix textbox textcolor not properly set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mkortstiege commentedJul 31, 2015
Follow-up of #7205. This ensures proper color handling in textboxes.
@BigNoid, mind testing? I've verified that both colors (textcolor + color tag) are working but i'd like to have another +1. Thanks.