Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[guilib] add Container(id).Position for grouplist controls #7866

Merged
merged 3 commits into from Sep 1, 2015

Conversation

mkortstiege
Copy link
Member

This adds Container(id).Position for grouplist controls.

/cc @BigNoid, @HitcherUK, @phil65, @ronie, @vonH

@mkortstiege mkortstiege added Type: Feature non-breaking change which adds functionality Type: Improvement non-breaking change which improves existing functionality labels Aug 20, 2015
@mkortstiege mkortstiege added this to the Jarvis 16.0-alpha3 milestone Aug 21, 2015
@mkortstiege
Copy link
Member Author

Would be nice if this could be tested.

@BigNoid
Copy link
Member

BigNoid commented Sep 1, 2015

Works as intended.

mkortstiege added a commit that referenced this pull request Sep 1, 2015
[guilib] add Container(id).Position for grouplist controls
@mkortstiege mkortstiege merged commit 8f5aa9a into xbmc:master Sep 1, 2015
@Hitcher
Copy link
Contributor

Hitcher commented Sep 1, 2015

Sorry I thought I'd already commented - works great. Thanks.

@Hitcher
Copy link
Contributor

Hitcher commented Sep 28, 2015

@mkortstiege Ran into a problem when the first item is hidden and the position gets set to 1 instead of 0. No problems when any other items are hidden.

EDIT: It might be a script problem actually.

@mkortstiege mkortstiege deleted the container-position branch October 6, 2015 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature non-breaking change which adds functionality Type: Improvement non-breaking change which improves existing functionality v16 Jarvis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants