Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[videodb] Never clean empty TV shows if the path still exists. #7904

Merged
merged 1 commit into from Aug 31, 2015

Conversation

Projects
None yet
10 participants
@ghost
Copy link
Contributor

ghost commented Aug 27, 2015

Split from #6024.

If I've reread the various comments there correctly, we agreed that TV shows with no episodes should never be removed from the database if the path still exists (and a specific setting is superfluous too).

@Montellese

@anaconda anaconda force-pushed the menakite:vclean-keep-empty-series branch from b07ce1b to 5cae3b5 Aug 27, 2015

@HitcherUK

This comment has been minimized.

Copy link
Contributor

HitcherUK commented Aug 27, 2015

Thanks.

@Montellese

This comment has been minimized.

Copy link
Member

Montellese commented Aug 27, 2015

Yeah should be good.

@MartijnKaijser MartijnKaijser added this to the Jarvis 16.0-alpha3 milestone Aug 27, 2015

@hudokkow

This comment has been minimized.

Copy link
Member

hudokkow commented Aug 28, 2015

jenkins build this please

@vbat99

This comment has been minimized.

Copy link

vbat99 commented Aug 28, 2015

Thank you. it has been annoying to see series removed during a clean, to re-appear again on Library Updates.

MartijnKaijser added a commit that referenced this pull request Aug 31, 2015

Merge pull request #7904 from anaconda/vclean-keep-empty-series
[videodb] Never clean empty TV shows if the path still exists.

@MartijnKaijser MartijnKaijser merged commit 7a472da into xbmc:master Aug 31, 2015

1 check passed

default Merged build finished.
Details

@anaconda anaconda deleted the menakite:vclean-keep-empty-series branch Aug 31, 2015

@un1versal

This comment has been minimized.

Copy link
Contributor

un1versal commented Sep 14, 2015

I removed a TV show from my NAS directory completely, then cleaned library and the whole content was removed as expected except for the TV show title Library entry in List view.

Up until this commit whenever I did this the lot was removed as expected, with this, the entry is left festering behind when it doesnt exist anywhere and no advancedsettings or any other settings is being used here.

Only solution was to delete entry manually.

@ghost

This comment has been minimized.

Copy link
Contributor Author

ghost commented Sep 14, 2015

@uNiversaI I've tried to reproduce this.
When cleaning TV shows:

  • we delete episodes that no longer exist;
  • we delete paths that no longer exist;
  • we delete the TV show if it has no paths associated.

Here:

  • a first library clean only deleted episodes and paths;
  • a second clean finally deleted the TV show.

Can you confirm this?
In that case, something here isn't working properly:
https://github.com/xbmc/xbmc/blob/master/xbmc/video/VideoDatabase.cpp#L7878-L7894
and the code removed by this PR only worked as a sort of "shortcut".

@un1versal

This comment has been minimized.

Copy link
Contributor

un1versal commented Sep 14, 2015

second clean dindt change anything I had to finally delete the empty entry manually.

See http://forum.kodi.tv/showthread.php?tid=238881

@Razzeee Razzeee added the v16 Jarvis label Nov 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.