Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addon installer: cleanup unused parameters and code #7997

Merged
merged 4 commits into from Sep 10, 2015

Conversation

@tamland
Copy link
Member

tamland commented Sep 8, 2015

Just trying to kill off some complexity. Removes the update and force parameters which are logically never used (every call is a "force" install).

Also, one fix where dependency installing ignores the disable state (probably not an issue as required deps should not be disabled in the first place)

@mkortstiege

This comment has been minimized.

Copy link
Member

mkortstiege commented Sep 9, 2015

Looks good to me.

@MartijnKaijser

This comment has been minimized.

Copy link
Member

MartijnKaijser commented Sep 9, 2015

jenkins build this please

@MartijnKaijser

This comment has been minimized.

Copy link
Member

MartijnKaijser commented Sep 9, 2015

jenkins build this please to be sure

@tamland

This comment has been minimized.

Copy link
Member Author

tamland commented Sep 10, 2015

unrelated

tamland added a commit that referenced this pull request Sep 10, 2015
addon installer: cleanup unused parameters and code
@tamland tamland merged commit 90fc2ec into xbmc:master Sep 10, 2015
1 check failed
1 check failed
default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.