Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON: replace YAJL with RapidJSON #8008

Merged
merged 4 commits into from Mar 24, 2017

Conversation

Projects
None yet
@Montellese
Copy link
Member

Montellese commented Sep 10, 2015

This is an approach at replacing our JSON parsing/writing done with YAJL with RapidJSON which, according to a lot of benchmarks (https://code.google.com/p/rapidjson/wiki/Performance, https://github.com/mloskot/json_benchmark, https://github.com/miloyip/nativejson-benchmark, http://chadaustin.me/2013/01/json-parser-benchmarking/) is one of the fastest JSON libraries available and a lot faster than YAJL. We are not likely to notice this a lot because most of the JSON we process is rather small but it certainly won't hurt either.

I've also written a few unit tests for the JSON parsing/writing (which are independent of the JSON library we use).

rapidjson doesn't seem to be available for Ubuntu so it would need to be added to our PPA. I also haven't uploaded the source tarball and the win32 dependency archive yet.

TODOs:

  • upload rapidjson-1.0.2.tar.gz to mirrors
  • upload rapidjson-1.0.2-win32.7z to mirrors
  • add rapidjson to PPA
obj["foo"] = "bar";
variant.push_back(obj);
ASSERT_TRUE(CJSONVariantWriter::Write(variant, str, false));
// TODO: ASSERT_TRUE(CJSONVariantWriter::Write("[ { \"foo\": \"bar\" } ]", variant));

This comment has been minimized.

@Razzeee

Razzeee Sep 10, 2015

Member

Forgot about this?

@Paxxi

This comment has been minimized.

Copy link
Member

Paxxi commented Sep 10, 2015

As it's a header only library can't we just stick this in contrib instead of handling it through depends?

@Montellese

This comment has been minimized.

Copy link
Member Author

Montellese commented Sep 10, 2015

@Paxxi: Personally I'd prefer not to put any 3rd party code into our repo.


enum class PARSE_STATUS
{
Variable = 0,

This comment has been minimized.

@Paxxi

Paxxi Sep 10, 2015

Member

No need to set values. Not even sure it's legal?

@Paxxi

This comment has been minimized.

Copy link
Member

Paxxi commented Sep 10, 2015

I'm split on the topic but we have started down that path with kissfft.

Code is looking good and I'm thinking with a bit of testing and the depends stuff taken care of it's good to merge.

@Montellese Montellese force-pushed the Montellese:rapidjson branch from 00f83a7 to bfdb69f Sep 10, 2015

@Montellese

This comment has been minimized.

Copy link
Member Author

Montellese commented Sep 10, 2015

Adressed the comments. Thanks for the feedback.

@Montellese Montellese force-pushed the Montellese:rapidjson branch from bfdb69f to 63e4d4a Sep 10, 2015

@Montellese

This comment has been minimized.

Copy link
Member Author

Montellese commented Sep 10, 2015

I've added an extra commit that enables SSE2 optimization on WIN32. Unfortunately this has to be specified at compile time and doesn't support runtime detection. But on WIN32 SSE2 support is mandatory. I have no idea about other platforms.

@Tolriq

This comment has been minimized.

Copy link
Contributor

Tolriq commented Sep 11, 2015

JSON encoding speed was a major problem on low end devices for syncing of database for remotes.

This needed to split queries to small ones and sending multiple request to webserver.

This was not optimal as this means also multiple queries to database with limits that also adds some slowness.

I'd be glad to test and report on those large json queries (multiple MB on large libraries) on Windows and rpi if @MilhouseVH can build the images.

Impact was also related to memory usage, don't know how to test, but memory usage of the encoder should be taken in account.

@Montellese

This comment has been minimized.

Copy link
Member Author

Montellese commented Sep 11, 2015

I've uploaded the rapidjson packages to our mirrors but it's gonna take an hour or so for them to be available. Then I can at least trigger a windows test build for you @Tolriq.

@stefansaraev

This comment has been minimized.

Copy link
Contributor

stefansaraev commented Sep 11, 2015

@Montellese fyi. rapidjson got a hardcoded -march=native in it's CMakeLists.txt. you need something like http://sprunge.us/HZbS

@Montellese

This comment has been minimized.

Copy link
Member Author

Montellese commented Sep 11, 2015

@stefansaraev: Actually I wrote a patch for that in rapidjson's depends integration but looks like I forgot to push that. Will do ASAP.

@Montellese Montellese force-pushed the Montellese:rapidjson branch 2 times, most recently from 9701709 to 42379c4 Sep 11, 2015

@Montellese

This comment has been minimized.

Copy link
Member Author

Montellese commented Sep 11, 2015

@Tolriq: WIN32 test build is running: http://jenkins.kodi.tv/job/WIN-32/6116/

@Tolriq

This comment has been minimized.

Copy link
Contributor

Tolriq commented Sep 11, 2015

@Montellese
Ok will be a little late for today I think, will try to check this week end, but for sure Monday, as speed gain on this would be great.

Any specific things that can have side effect ? Like null handling or empty arrays ?

@Montellese

This comment has been minimized.

Copy link
Member Author

Montellese commented Sep 11, 2015

Theoretically it should be identical in behaviour.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

MilhouseVH commented Sep 11, 2015

@stefansaraev has kindly provided me with a patch to add RapidJSON to OE (adding new packages really isn't my thing!) - if all goes well this PR will be included in tonight's build. What's the best way to test the change, just call the existing JSON API methods?

@Montellese

This comment has been minimized.

Copy link
Member Author

Montellese commented Sep 11, 2015

@MilhouseVH: cool thanks. Yeah just use the JSON-RPC API.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

MilhouseVH commented Sep 12, 2015

Can this be rebased now that #8018 has merged?

@Montellese Montellese force-pushed the Montellese:rapidjson branch from 42379c4 to e34ae15 Sep 13, 2015

@Montellese

This comment has been minimized.

Copy link
Member Author

Montellese commented Sep 13, 2015

@MilhouseVH: done. jenkins build this please

@wsnipex

This comment has been minimized.

Copy link
Member

wsnipex commented Sep 14, 2015

whats the required min version? ubuntu >=15.04 has a (rather old) package: https://launchpad.net/ubuntu/+source/rapidjson

@Montellese

This comment has been minimized.

Copy link
Member Author

Montellese commented Sep 14, 2015

@wsnipex: I've downloaded the latest release v1.0.2 but I didn't check any previous releases. I have no clue what state version 0.12 is in that is available on Ubuntu. I was only able to find 0.11 and 1.0 so not sure what they are doing there.

@Tolriq

This comment has been minimized.

Copy link
Contributor

Tolriq commented Sep 14, 2015

@Montellese After quite some test all seems to work perfectly.

For speed well all my windows machine are quite fast so even on 12MB JSON files there's no difference between this and normal Jarvis build.

Only bug I get was invalid json data when asking for getEpisodes during a scrape, but I'm pretty sure this is a more global bug and not related to this PR.

@wsnipex

This comment has been minimized.

@L-S-D

This comment has been minimized.

Copy link

L-S-D commented Sep 16, 2015

since this PR is included in Milhouses OE test builds, I'm no longer able to list channels in Kodi Remote for IOS. I get the following JSON error in the app:

XBMC JSON-RPC Error: Invalid params.
(Code: -32602)
Data: (null)

METHOD
PVR.GetChannels

PARAMETERS
{channelgroupid=5;properties=(thumbnail,channel);}

@Montellese

This comment has been minimized.

Copy link
Member Author

Montellese commented Mar 28, 2017

@candrews: as @Rechi mentioned it's already in the works.

Concerning distributions upgrading rapidjson to 1.1.0 I'm not so worried since Ubuntu Zesty is still at 0.12 which is from 2014 and not even a real release ;-) We already have to provide our own PPA build.

@FernetMenta

This comment has been minimized.

Copy link
Member

FernetMenta commented on tools/depends/target/rapidjson/Makefile in 15017d8 Apr 9, 2017

this is not required when not cross compiling

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 9, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 10, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 12, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 13, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 13, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 13, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 14, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 14, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 14, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 15, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 15, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 17, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 17, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 17, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 17, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 18, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 18, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 19, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 19, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 20, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 20, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 21, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 22, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 22, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 22, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 23, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 23, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-cmake-add-FindIconv.cmake.patch
- 0003-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008

Signed-off-by: fli4l <fli4l@fli4lbuild64.lan.fli4l>

bkuhls added a commit to bkuhls/buildroot that referenced this pull request Apr 24, 2017

package/kodi: bump to version 18.0-Leia
Rebased patches
- 0001-kodi-config.cmake-use-CMAKE_FIND_ROOT_PATH-to-fix-cr.patch
- 0002-CMake-Remove-dependency-on-gmp-and-libintl-from-Find.patch
after move of project/cmake in xbmc/xbmc#10446

Updated dependencies
- fmt
  xbmc/xbmc#11039
- yajl was replaced by RapidJSON
  xbmc/xbmc#8008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.