New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align video and music sort types on file listings to each other #8184
Conversation
No idea if anyone is using Apart from that it looks good. |
Well it might. Haven't thought of that yet. |
When I browse into the video files node I get the actual movie name for all movies that have been added to the library (with artwork and all the fancy stuff) and the folder/filename for everything that hasn't been added to the library. So there certainly can be differences between |
That happens when you enable the video library setting - 'Replace file names with library titles'. So are we going to have the same for music? |
I'm not sure if I like the implementation then, should what is in label really depend on what's the sort type? If yes, why is this the only place we use it like this. |
I never said that the label changes when you change the sort method. The label always stays the same but when using |
b6624a7
to
b4e7f7f
Compare
@Montellese |
Yup, fine with me. Thanks for checking pictures. |
Align video and music sort types on file listings to each other
@razzeee from your recent work in this area, could you tell me what changes can best be made to CGUIViewStateWindowMusicNav creator that will reinstate the music file view sorting and display functionality as we have in Isengard but seem to have inadvertently lost in Jarvis? Since #8011 we stopped using GUIWindowMusicSongs.cpp, and this was providing sorting (I think) that |
This removes one redundant search type from video file lists and aligns the music file lists to the ones in video.
As @Hitcher asked for this
@Montellese or @mkortstiege for review probably