Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[gui] fix missing path param in CGUIDialog::Open() after 447ec5b #8194
2 times, most recently
Oct 10, 2015
Was testing this PR to see if it improved http://trac.kodi.tv/ticket/16314
So here hoping this isnt merged as is.
@xhaggi - Still both apply, sadly codecinfo also not working while the working dialog is up btw.
Well, here is a retest, more in depth.
local files this is OK, but via NFS/SMB triggers the working dialog and thats all she wrote.
What happens exactly is this.
Press play on any file target NFS/SMB source in your library.
Yesterday, I didnt test with local files so have no means of comparison.
Given you're only calling Open() with the parameter in ActivateWindow(), this can't possibly work, no?
You must override the function you're actually calling from outside the class. In this case, Open is always called with the parameter from outside the class, so you either need to call the parameter-less one from inside the one with the parameter (doesn't make sense) or override the parameter version.
Note that only Open_Internal() need be virtual (just like only DoModal_Internal was virtual before).