Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[texture] redact username/password when texture loading fails #8241

Merged
merged 1 commit into from Oct 18, 2015

Conversation

@mkortstiege
Copy link
Member

mkortstiege commented Oct 17, 2015

Ensure we're not logging username/password in case the texture loading fails. Happens eg. when loading channel unavailable logos from tvh and most likely others.

@Jalle19

This comment has been minimized.

Copy link
Member

Jalle19 commented Oct 18, 2015

Sounds reasonable.

jenkins build this please

@Razzeee

This comment has been minimized.

Copy link
Member

Razzeee commented Oct 18, 2015

Maybe even backport this if we do another one for that tvtunes change?

@mkortstiege

This comment has been minimized.

Copy link
Member Author

mkortstiege commented Oct 18, 2015

Maybe even backport this if we do another one for that tvtunes change?

In case we're doing another RC, sure. Btw, the confluence backport in question is handled differently as it's a regular addon and no core change.

mkortstiege added a commit that referenced this pull request Oct 18, 2015
[texture] redact username/password when texture loading fails
@mkortstiege mkortstiege merged commit 42e3080 into xbmc:master Oct 18, 2015
1 check passed
1 check passed
default Merged build finished.
Details
@Razzeee

This comment has been minimized.

Copy link
Member

Razzeee commented Oct 18, 2015

Then forget about my comment. :)

@Razzeee Razzeee added v16 Jarvis and removed v16 Jarvis labels Oct 22, 2015
@mkortstiege mkortstiege deleted the mkortstiege:texture-logging branch Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.