Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Reset invalidated flag only if we processed control #826

merged 1 commit into from Mar 29, 2012


None yet
2 participants

pieh commented Mar 29, 2012

This is fix for scrollbar not updating its range if it's not visible (one Jezz_X found in confluence-lite and global search).

Reason for this bug is simple - we don't process not visible controls, but we reset invalid flag every frame - so control simply misses that invalid flag (in scrollbar case - it won't adjust nib size and position).

Alternative fix would be to process not visible control if it has invalided flag set

if (IsVisible() || m_invalidated)
     Process(currentTime, dirtyregions);

@ghost ghost assigned pieh Mar 29, 2012


jmarshallnz commented Mar 29, 2012

Pretty sure this should be fine. The reseting is better (IMO) than always processing (less processing for controls that are set invalid over multiple frames while invisible).

pieh added a commit that referenced this pull request Mar 29, 2012

Merge pull request #826 from pieh/invalid_flag
Reset invalidated flag only if we processed control

@pieh pieh merged commit f24a03d into xbmc:master Mar 29, 2012

HolgerW1 pushed a commit to HolgerW1/xbmc that referenced this pull request Sep 26, 2014

Merge branch 'PR-826_rawhd_update' into development
* PR-826_rawhd_update: closes gh-826
  Adding rawhd support to catch releases like `Veep.S03E02.1080p.HDTV.DD5.1.H.264-NorTV`.

HolgerW1 pushed a commit to HolgerW1/xbmc that referenced this pull request Sep 26, 2014

Merge branch 'development'
Post-Processor tweaks
  * Ignores folders that start with `_unpack` or `_UNPACK`
  * If unable to figure out the quality from the filename, fallback
    to the episode (snatched) status
  * Other minor fixes and fixes to logging / when checks are applied.
    Commit 96d64e6

Change SB's git/source update routine to hopefully resolve the bug on
updating if you were more than 100 commits behind.

Cleanup Notifiers code. Pull #814 #823
  * Add **Always On** option for XBMC to control if sb should suppress errors
    when XBMC is offline or not.
  * Add logic to notifiers js to catch empty required fields to prevent
    unneeded testing calls.
  * Mention sending notices to Plex Home Theater (PHT), to use XBMC
    (since it mimics xbmc's json api) but with port 3005.

Update **tvdb_api** to latest. Pull #820

NZBGet update. Pull #821
  * Ported Prinz23's NZBGet 9+ appendurl + dupecheck/dupescore code from
    mr-orange's branch.
  * Fix username:password containing special characters.

Tweaked regex to filter out more subbed releases in case the indexer
did not assign them to the foreign category.
ex: `Bates.Motel.S02E07.REAL.PROPER.HDTV.XviD.HebSubs-DR`

Added `webm` to supported media extensions.

Update *rawHD* to support releases
like `Veep.S03E02.1080p.HDTV.DD5.1.H.264-NorTV`. Pull #826

Update local js for jquery 1.9.x compatibility and tweak _browser.js_. Pull #824
  * Added hack that allows users to specify `\\server\path` for a location
    and we load this as the initalDir browse path instead of previously saved value.
  * Set current path to what path we actually did load, in case the previous
    directory was not valid (we load parent folder instead)

Upgrade several js libs to fix IE related issues or to prepare for
upcoming jquery upgrade.
  * Upgrade _tablesorter_ 2.14 -> 2.16.3. Pull #827
  * Upgrade _jquery.form_ 3.35 -> 3.50 Pull #825
    * Fixed Config > Post Processing page not using ajaxForm.

Updated SB-Update message and the Config > Help & Info page to reflect
binary builds are now on GitHub instead of GoogleCode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment