Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: [droid] surface rendering mediacodec #8277

Merged
merged 3 commits into from Oct 23, 2015

Conversation

Projects
None yet
3 participants
@koying
Copy link
Contributor

koying commented Oct 22, 2015

This creates a virtual codec from mediacodec, where only the rendering path changes.
The "Surface" way implement zero-copy, hw codec to android surface rendering.

Besides the fact that it's the android "by-the-book" way, it also enables 4K video playing on 720p/1080p framebuffer, composition being left to the FW.
This should also work on all FW's, ideally, as the FW is completely in charge from decoding to rendering.

At the same time, this also de-activate libstagefright.

Initially, I planned to implement this in videoplayer only, but I'd rather have a smoother transition in 16, rather than a big-bang in 17. Furthermore, more 4K devices (TV's, AFTV2) are coming, and waiting till 17 will make us quite behind.

@FernetMenta Hope you don't mind. I've limited the impact to the maximum (no cleanup whatsoever) to limit the rebasing issues on videplayer. If you still have some, I suggest to plainly revert 76c4415 in your branch, and I'll re-implement in videoplayer.

@MartijnKaijser Hope it's not too late for 16?

@FernetMenta

This comment has been minimized.

Copy link
Member

FernetMenta commented Oct 22, 2015

ok, recently git showed that it is quite clever on renamed files. should not result in too much pain.

@MartijnKaijser

This comment has been minimized.

Copy link
Member

MartijnKaijser commented Oct 22, 2015

If @FernetMenta is OK with it I'm OK with it.
Although it looks more like a feature it fixes something that has been biting us for a while on android. Should be merged as soon as we can

@koying koying force-pushed the koying:addamcsurface branch 2 times, most recently from 2806728 to 482b358 Oct 22, 2015

@koying

This comment has been minimized.

Copy link
Contributor Author

koying commented Oct 22, 2015

jenkins build this please

@MartijnKaijser

This comment has been minimized.

Copy link
Member

MartijnKaijser commented Oct 22, 2015

Build errors are only for Addons

@koying

This comment has been minimized.

Copy link
Contributor Author

koying commented Oct 22, 2015

Yep. Just noticed an issue with 3d (same as imx) that I'll fixup tomorrow.

Le jeu. 22 oct. 2015 21:08, Martijn Kaijser notifications@github.com a
écrit :

Build errors are only for Addons


Reply to this email directly or view it on GitHub
#8277 (comment).

@koying koying force-pushed the koying:addamcsurface branch from 482b358 to 432b77a Oct 23, 2015

@koying koying force-pushed the koying:addamcsurface branch from 432b77a to 23b88a7 Oct 23, 2015

koying added a commit that referenced this pull request Oct 23, 2015

Merge pull request #8277 from koying/addamcsurface
ADD: [droid] surface rendering mediacodec

@koying koying merged commit 3516427 into xbmc:master Oct 23, 2015

@koying koying deleted the koying:addamcsurface branch Oct 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.