Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] remove karaoke support #8285

Merged
merged 1 commit into from Oct 25, 2015

Conversation

Projects
None yet
8 participants
@mkortstiege
Copy link
Member

mkortstiege commented Oct 24, 2015

As requested by a lot of team members ..
Needs testing before merge!

@mkortstiege

This comment has been minimized.

Copy link
Member Author

mkortstiege commented Oct 24, 2015

jenkins build this please.

@MartijnKaijser

This comment has been minimized.

Copy link
Member

MartijnKaijser commented Oct 24, 2015

tested! :D

@ronie

This comment has been minimized.

Copy link
Member

ronie commented Oct 24, 2015

@fritsch

This comment has been minimized.

Copy link
Member

fritsch commented Oct 24, 2015

I think it can come back as an addon easily after @AchimTuran AESource interface has landed.

@ronie

This comment has been minimized.

Copy link
Member

ronie commented Oct 24, 2015

@mkortstiege

This comment has been minimized.

Copy link
Member Author

mkortstiege commented Oct 24, 2015

Updated. will squash later.

@ronie

This comment has been minimized.

Copy link
Member

ronie commented Oct 24, 2015

don't forget to revert en_us ;-)

@mkortstiege

This comment has been minimized.

Copy link
Member Author

mkortstiege commented Oct 24, 2015

don't forget to revert en_us ;-)

It's part of "some more .."

@mkortstiege mkortstiege force-pushed the mkortstiege:y_u_no_sing_with_me branch from a40eead to a46acf6 Oct 24, 2015

@mkortstiege

This comment has been minimized.

Copy link
Member Author

mkortstiege commented Oct 24, 2015

Squashed. jenkins build this please.

@MartijnKaijser MartijnKaijser added this to the Jarvis 16.0-alpha4 milestone Oct 24, 2015

@MartijnKaijser

This comment has been minimized.

Copy link
Member

MartijnKaijser commented Oct 24, 2015

@FernetMenta how much will this hurt your rebase?

@FernetMenta

This comment has been minimized.

Copy link
Member

FernetMenta commented Oct 25, 2015

@MartijnKaijser should be fine. Removals only will not result in any hard to resolve merge conflicts.

MartijnKaijser added a commit that referenced this pull request Oct 25, 2015

@MartijnKaijser MartijnKaijser merged commit 6869b33 into xbmc:master Oct 25, 2015

1 check failed

default Merged build finished.
Details

@mkortstiege mkortstiege deleted the mkortstiege:y_u_no_sing_with_me branch Oct 26, 2015

@@ -3934,11 +3896,15 @@ void CMusicDatabase::UpdateTables(int version)
m_pDS->exec("DROP TABLE album");
m_pDS->exec("ALTER TABLE album_new RENAME TO album");
}
if (version < 55)

This comment has been minimized.

@Razzeee

Razzeee Nov 16, 2015

Member

This should be versio < 56 and therfore align with GetSchameVersion. Otherwise people going from 55 to 56 won't get this dropped. Small issue, but yeah.
Or we bump both to 57

@un1versal

This comment has been minimized.

Copy link
Contributor

un1versal commented Nov 16, 2015

great! lets get the xbox out again

@MartijnKaijser

This comment has been minimized.

Copy link
Member

MartijnKaijser commented Nov 16, 2015

Keep the comments somewhere else

@wyrm65

This comment has been minimized.

Copy link

wyrm65 commented Nov 17, 2015

@mkortstiege, sorry mate would appear to be close but no cigar. Jarvis Beta1 on windows build is showing this in the log

12:25:52 T:5504 INFO: Loading skin file: DialogMuteBug.xml, load type: LOAD_ON_GUI_INIT
12:25:52 T:5504 ERROR: Window Translator: Can't find window karaokeselector
12:25:52 T:5504 ERROR: Window Translator: Can't find window karaokelargeselector
12:25:52 T:5504 INFO: Loading skin file: DialogSeekBar.xml, load type: LOAD_ON_GUI_INIT
12:25:52 T:5504 ERROR: Window Translator: Can't find window karaoke

After removing the skin files as per Jarvis skin requirements, Kodi is still looking for the files. I suspect you did not get everything you should have.

@ronie

This comment has been minimized.

Copy link
Member

ronie commented Nov 17, 2015

@wyrm65 are you 100% sure you're running beta 1?
please post a link to a full debuglog.

edit: check your DialogMuteBug.xml and DialogSeekBar.xml files.
they probably reference the karaoke windows, hence you get those log errors.

@wyrm65

This comment has been minimized.

Copy link

wyrm65 commented Nov 18, 2015

@ronie yep 100% sure on ,"am I running beta 1".

Yes you were right on the DialogMuteBug.xml and DialogSeeBar.xml files (plus a couple of others). You might want to drop a hint for others in the skin update thread so they don't also look like a goose like me. PEBCAK error, Kodi beta 1 is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.