Remove a useless join in season_view #8375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, thank you! |
razzeee
added
Type: Improvement
|
@mkortstiege for ok as well. Still in time I guess for v16 else delay? |
phate89
force-pushed
the
remove_useless_join
branch
from
a4387bb
to
e4188de
Compare
|
I updated the pr. There was no need to use episode_view since we need only files and episode tables so I put back the files join and replaced episode_view with episode. |
|
Should be good. |
|
jenkins build this please |
MartijnKaijser
added a commit
that referenced
this pull request
Dec 5, 2015
Remove a useless join in season_view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I' not wrong in season_view you already have playcount in episode_view. No need to join again files table to get it