don't toggle DisplayAfterSeek on ShowTime builtin command #8547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronie
added
Type: Fix
|
@xhaggi could you give your opinion? |
|
not sure what the reason was, but it makes sense to leave it up to the skinner if he wants to display the seekbar dialog. |
|
jenkins build this please |
MartijnKaijser
added a commit
that referenced
this pull request
Jan 23, 2016
don't toggle DisplayAfterSeek on ShowTime builtin command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a user uses the ShowTime action, we (correctly) toggle the Player.ShowTime infobool
but we also toggle Player.DisplayAfterSeek for some reason?
this causes the skin to display an incorrect label in the SeekBar dialog.
if the only reason for the DisplayAfterSeek toggle is to trigger the visibility of the SeekBar dialog
then this commit will fix the ticket.
http://trac.kodi.tv/ticket/16434