[ffmpeg] Convert from av_audio_convert API to the swresample one. #882

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
@aballier
Contributor

aballier commented Apr 14, 2012

That way we can drop usage of the internal av_audio_convert API.

aballier added some commits Apr 14, 2012

SwResample: Map swr_alloc_set_opts, swr_init, swr_free and swr_conver…
…t functions.

That way we can use the libswresample API instead of the private libavcodec::audioconvert API.
[dvdplayer]: Use the SwResample API.
This drops all usage of the private libavcodec::audiocovert API in xbmc.
@elupus

This comment has been minimized.

Show comment
Hide comment
@elupus

elupus Apr 15, 2012

Member

@amejia1 So here we come to the next libav issue. They have not merged back libswresample...

Member

elupus commented Apr 15, 2012

@amejia1 So here we come to the next libav issue. They have not merged back libswresample...

@elupus

This comment has been minimized.

Show comment
Hide comment
@elupus

elupus Apr 15, 2012

Member

@aballier don't take above as me not wanting to merge this. I really do.

Member

elupus commented Apr 15, 2012

@aballier don't take above as me not wanting to merge this. I really do.

@amejia1

This comment has been minimized.

Show comment
Hide comment
@amejia1

amejia1 Apr 15, 2012

Member

@elupus libav are to make libavresample available soon. See http://lists.libav.org/pipermail/libav-devel/2012-April/025629.html

Not sure how different this is than libswresample yet.

Member

amejia1 commented Apr 15, 2012

@elupus libav are to make libavresample available soon. See http://lists.libav.org/pipermail/libav-devel/2012-April/025629.html

Not sure how different this is than libswresample yet.

@amejia1

This comment has been minimized.

Show comment
Hide comment
@amejia1

amejia1 Apr 15, 2012

Member

@elupus ok, as to the two lib*resample libs being incompatible, the answer is yes, they are completely incompatible.

Member

amejia1 commented Apr 15, 2012

@elupus ok, as to the two lib*resample libs being incompatible, the answer is yes, they are completely incompatible.

@elupus

This comment has been minimized.

Show comment
Hide comment
@elupus

elupus Apr 15, 2012

Member

How utterly stupid..

Member

elupus commented Apr 15, 2012

How utterly stupid..

@amejia1

This comment has been minimized.

Show comment
Hide comment
@amejia1

amejia1 Apr 26, 2012

Member

Ok, libav implemented libavresample and ffmpeg merged it.

@elupus Michael did the merge. Here is his reason https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2012-April/123746.html

Member

amejia1 commented Apr 26, 2012

Ok, libav implemented libavresample and ffmpeg merged it.

@elupus Michael did the merge. Here is his reason https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2012-April/123746.html

@elupus

This comment has been minimized.

Show comment
Hide comment
@elupus

elupus Jul 5, 2012

Member

Would be nice to get this pull request updated. Either to libavresample or libswresample

Member

elupus commented Jul 5, 2012

Would be nice to get this pull request updated. Either to libavresample or libswresample

@aballier

This comment has been minimized.

Show comment
Hide comment
@aballier

aballier Jul 5, 2012

Contributor

yes, i've had absolutely no time to work on xbmc lately, though, imho, we should support both with a preference over libswresample if available: it is only available withing ffmpeg and they promised (are?) to port the libavresample improvements to swr.

Contributor

aballier commented Jul 5, 2012

yes, i've had absolutely no time to work on xbmc lately, though, imho, we should support both with a preference over libswresample if available: it is only available withing ffmpeg and they promised (are?) to port the libavresample improvements to swr.

@aballier aballier closed this Jul 6, 2012

@aballier

This comment has been minimized.

Show comment
Hide comment
@aballier

aballier Jul 6, 2012

Contributor

lets close this for now, i'll reopen a new one rebased on current master

Contributor

aballier commented Jul 6, 2012

lets close this for now, i'll reopen a new one rebased on current master

mikedm139 pushed a commit to mikedm139/plex-home-theater-public that referenced this pull request Nov 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment