Fix testsuite after rating changes #8835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TestCharsetConverter.wToUTF8 on windows is around for a long time. I think nobody knows how to properly fix it :( |
|
Hrm, no clue why that CriticalSection crash is there (I also get it) |
|
would you have a bt for the crash? |
|
Doesn't seem to create a crashlog, heres what's in the call stack in visual studio. Edit: None of the affected code paths mentioned in the callstack changed recently. |
|
The critical section thing is out of scope for this PR. |
|
jenkins build and merge |
|
Thanks for taking care of it! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the @hudokkow commit and finish the fixed related to my rating changes.
There is still a failed test (TestCharsetConverter.wToUTF8) and a crash (in CriticalSection.h) that are not related to my changes and I don't know how to fix