[PVR] Fix crash after selecting 'Add timer' in PVR timer window, closes Trac16539 #8962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Fix
ksooo
force-pushed
the
jarvis-trac16539
branch
from
e7da31f
to
1a4822b
Compare
|
jenkins build this please |
|
@stefansaraev maybe you can give this a try with pvr.stalker and report back? |
|
will do tonight. thanks. |
|
@ksooo I tested in on master, an still crashing http://sprunge.us/MjXC |
… backend does not support timers (fixes trac#16539)
…s not support timers.
ksooo
force-pushed
the
jarvis-trac16539
branch
from
1a4822b
to
e15ed4c
Compare
|
@stefansaraev ooops. Better now? And please, use Jarvis + this PR. Did same mistake on master, unfortunately already merged there. Needs another PR for fix on master. |
|
no way I can test jarvis but I adapted your change to CGUIWindowPVRTimersBase::ActionShowTimer in master and no crash anymore. I get an okdialog instead. thanks much. |
|
jenkins build this please |
|
win-32 jenkins error is unrelated @MartijnKaijser your button |
MartijnKaijser
added a commit
that referenced
this pull request
Jan 28, 2016
[PVR] Fix crash after selecting 'Add timer' in PVR timer window, closes Trac16539
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #8960
@seo maybe you can give this a try with pvr.stalker and report back?