Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix library path for child addons #9342

Merged
merged 1 commit into from Mar 13, 2016
Merged

Conversation

FernetMenta
Copy link
Contributor

see title

@wsnipex @mapfau this should fix the wrong path. it also makes sure the old libs in temp won't get used.

@FernetMenta FernetMenta added Type: Fix non-breaking change which fixes an issue v17 Krypton Component: Add-ons labels Mar 13, 2016
@wsnipex
Copy link
Member

wsnipex commented Mar 13, 2016

thanks

@fritsch
Copy link
Member

fritsch commented Mar 13, 2016

Verified working.

Offtopic:
Something else (and most likely offtopic) the decrypter directory is still assumed in /usr/share/kodi/addons/inpustream.mpd/ and not in /usr/lib where those should be.

@FernetMenta
Copy link
Contributor Author

jenkins build this please

@garbear
Copy link
Member

garbear commented Mar 13, 2016

@fritsch I may have run into this problem. I need the following patch for retroplayer: garbear@3fcbf62a7

@FernetMenta can I ask what you're doing that needs child addons?

@fritsch
Copy link
Member

fritsch commented Mar 13, 2016

@garbear thx - your code looks to solve this issue.

@FernetMenta
Copy link
Contributor Author

@garbear https://github.com/xbmc/xbmc/blob/master/xbmc/cores/VideoPlayer/DVDInputStreams/DVDFactoryInputStream.cpp#L67

Creating an object by passing the parent to the constructor creates a clone/child

@ghost
Copy link

ghost commented Mar 13, 2016

Offtopic:
Something else (and most likely offtopic) the decrypter directory is still assumed in >/usr/share/kodi/addons/inpustream.mpd/ and not in /usr/lib where those should be.

I call if (!xbmc->GetSetting("__addonpath__", path)) to retrieve the decrypter path.
So maybe there is smething not ok when resolving the special: at this implementation??

@FernetMenta
Copy link
Contributor Author

@mapfau unfortunately it's not that simple. During development the addon and libs are in the same folder. But when installed the arch independent files go to a different place than the arch dependent ones.

I can pass both paths to the addon with props an create.

@ghost
Copy link

ghost commented Mar 13, 2016

@FernetMenta This would be great! I would use the installation path of the bnary addon + /decrypters then.

FernetMenta added a commit that referenced this pull request Mar 13, 2016
fix library path for child addons
@FernetMenta FernetMenta merged commit 0bdefc0 into xbmc:master Mar 13, 2016
@FernetMenta FernetMenta deleted the libpath branch March 13, 2016 20:41
@razzeee razzeee added this to the Krypton 17.0-alpha1 milestone Mar 14, 2016
@ghost
Copy link

ghost commented Mar 14, 2016

OT: the libcurl.dll library wich currently comes precompiled with date from 05.2015 seems to have an bug when reading gzipped, chunked data. Windows users arrive the problem, that regarding the size of the chunks a .mpd file can not be parsed.

I have tried my 7.47 version and there are no errors at all.

What is the correct way to place a wish to update the CURL version at least for windows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Add-ons Type: Fix non-breaking change which fixes an issue v17 Krypton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants