Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[Confluence] added volume control via slider #937

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

mad-max commented May 5, 2012

Hey guys,

based on #764, I reworked the volume control to have a slider.
Basically this adds a new group to VideoOSD and MusicOSD that has the same look and feel like
"DialogVolumeBar" but can control the volume.

Unfortunately I do not have a touch device, so I'm not sure if this is suitable for it due to the hidden button.
So maybe someone with a touch device can test and or tell me if it is working.

Or maybe there can be a !System.Platform.IOS to avoid confusion there.

Any opinion on this?
Any things that need to be changed?

cheers,
mad-max

@ghost ghost assigned JezzX May 5, 2012

Owner

MartijnKaijser commented Jul 24, 2013

@ronie / @JezzX
will we use this or not?

Member

ronie commented Jul 25, 2013

the fact that the volume control is hidden by default makes little sense to me?
if people don't know it's there they won't use it.

volume control might be useful for touch devices, but if it's hidden
i wouldn't know which part of the screen to touch to activate it.

Owner

MartijnKaijser commented Aug 14, 2013

Sorry won't be added

@mad-max mad-max deleted the mad-max:volume_slider branch Mar 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment