[mmal] Add zero copy interface to ffmpeg #9384
Merged
Conversation
|
ping @FernetMenta |
xbmc/linux/rpi_user_vcsm.h
Outdated
| * | ||
| */ | ||
|
|
||
| #ifndef __USER_VCSM__H__INCLUDED__ |
FernetMenta
Mar 18, 2016
Contributor
I am not aware of any compile not supporting "pragma once"
I am not aware of any compile not supporting "pragma once"
xbmc/linux/rpi_user_vcsm.h
Outdated
| @@ -0,0 +1,440 @@ | |||
| /* | |||
| * Copyright (C) 2015-2016 Raspberry Pi (Trading) Ltd. | |||
FernetMenta
Mar 18, 2016
Contributor
shouldn't this files be places into a folder named pri?
shouldn't this files be places into a folder named pri?
| #ifdef HAS_MMAL | ||
| if (*cur == AV_PIX_FMT_YUV420P) | ||
| { | ||
| CDecoder* dec = new CDecoder(); |
FernetMenta
Mar 18, 2016
Contributor
namespace is missing
namespace is missing
|
Looks good! Only some minors, see comments. |
|
@FernetMenta I've added commits addressing your comments. |
|
+1 |
|
jenkins build this please |
popcornmix
added a commit
that referenced
this pull request
Mar 18, 2016
[mmal] Add zero copy interface to ffmpeg
|
nice, gives me some ideas about using darwin surfaces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This allows the allocation of buffers used by ffmpeg to come from the gpu.
Then we use MMALRenderer to display the buffers through an opaque pointer.
This avoids two copies of the pixel data (on in kodi and one in transfer to GPU) with software decode.
There is a quite a big performance benefit for this, and allows for example 1080p BluRay decode of MPEG-2 without a hardware codec licence, and improves HEVC support.